feat(apigatewayv2): http api - custom domain & stage mapping

[pahud]

• implementation
• README
• integ test
• 100% unit test coverage

Commit Message

feat(apigatewayv2): http api - custom domain & stage mapping (#8027)

• Add new DomainName and HttpApiMapping construct classes and addDomainName() method for HttpApi resource.
• Add defaultDomainMapping construct property for HttpApi
• Add domainMapping attribute for addStage

Closes #7847

End Commit Message

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[pahud]

Hi @nija-at

I am ready now :-)

[nija-at]

It seems that HttpApiMapping and DomainName constructs are common to both Websocket and HTTP APIs. I can't find any properties that are available to one but not the other.

Let's move these to the common/ folder instead so they can be shared.

You may have to create an IApi interface that will sit between IHttpApi and IResource as -

export interface IApi extends IResource {
  ...
}

export IHttpApi extends IApi {
  ...
}

Pull request has been modified.

[pahud]

Hi @nija-at

As there's only one attribute in IHttpApi, I am not sure if we should make a IApi between IHttpApi and IResource in this PR. But I've moved some interfaces of domain name and api mapping into common. Please kindly review it again.

aws-cdk/packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts

Lines 10 to 16 in 01fa408

	export interface IHttpApi extends IResource {
	/**
	* The identifier of this API Gateway HTTP API.
	* @attribute
	*/
	readonly httpApiId: string;
	}

[nija-at]

Thanks @pahud. Some comments below -

Pull request has been modified.

[nija-at]

Hey Pahud. A few things to take care of and from the previous comments.

Should be easy and this should be ready to go 😊

Pull request has been modified.

[pahud]

@nija-at all comments should be all sorted but my laptop can't build it successfully. I'm still trying to get it sorted. FYI.

[pahud]

OK I am ready.

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 4fa394c
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).