Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(batch): update README #8214

Merged
merged 4 commits into from
Jul 6, 2020
Merged

docs(batch): update README #8214

merged 4 commits into from
Jul 6, 2020

Conversation

stephnr
Copy link
Contributor

@stephnr stephnr commented May 26, 2020

This should be the final docs update based on the recent changes to:

  • Introduce Batch support
  • Fix issues with managed/unmanaged compute envs

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@stephnr
Copy link
Contributor Author

stephnr commented May 26, 2020

This PR is a continuance of a prior PR that was closed and unrecoverable. This PR should continue off the last set of comments/review with @iliapolo seen here:

https://github.com/aws/aws-cdk/pull/6931/files/d7598c69b07c79f6a1e8f09ab9d4361a581d1379

@iliapolo
Copy link
Contributor

@stephnr why is the previous PR not recoverable? Can't you re-open? I'd really like to stick to the original one since it contained a lot of comments...

@iliapolo
Copy link
Contributor

@stephnr Should I start reviewing this?

@stephnr
Copy link
Contributor Author

stephnr commented May 26, 2020

I have finished making all the changes as you recommended @iliapolo. Again, I do apologize for the delay 🙇

@stephnr
Copy link
Contributor Author

stephnr commented May 26, 2020

@stephnr why is the previous PR not recoverable? Can't you re-open? I'd really like to stick to the original one since it contained a lot of comments...

I did force pushes and then rolled back using my local reflog in git. But GitHub didn't recognize any of the changes even after I made them and pushed.

@iliapolo iliapolo self-requested a review May 26, 2020 21:17
@iliapolo iliapolo self-assigned this May 26, 2020
@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a6ad166
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a035784 into aws:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants