Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stepfunctions-tasks): task construct to call RunJob on ECS #8451

Merged
merged 33 commits into from
Jun 30, 2020
Merged

feat(stepfunctions-tasks): task construct to call RunJob on ECS #8451

merged 33 commits into from
Jun 30, 2020

Commits on Jun 9, 2020

  1. set up ecs base class

    @shivlaks
    shivlaks committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    bd88a21 View commit details
    Browse the repository at this point in the history

  2. wip

    @shivlaks
    shivlaks committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    277fc95 View commit details
    Browse the repository at this point in the history

  3. add integ tests, update README

    @shivlaks
    shivlaks committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    c0ba4c7 View commit details
    Browse the repository at this point in the history

  4. add anchor links in README

    @shivlaks
    shivlaks committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    40fb7bf View commit details
    Browse the repository at this point in the history

  5. mark old implementations as deprecated

    @shivlaks
    shivlaks committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    d2511e2 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into shivlaks/sfn-ecs-tasks

    @shivlaks
    shivlaks committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    28f5eac View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2020

  1. PR feedback

    @shivlaks
    shivlaks committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    f6e3f0d View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. Merge branch 'master' into shivlaks/sfn-ecs-tasks

    @shivlaks
    shivlaks committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    96feec1 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. add support for specifying fargate platform version

    @shivlaks
    shivlaks committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    c63756f View commit details
    Browse the repository at this point in the history

  2. drop run task as the current organization is favorable to implementin… 

    …g the bind pattern
    @shivlaks
    shivlaks committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    0c7b263 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2020

  1. PR feedback - single RunTask class with bind pattern to add fargate/e… 

    …cs props. folded all the logic in and removed abstract class
    @shivlaks
    shivlaks committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    da6ee70 View commit details
    Browse the repository at this point in the history

  2. remove unused task base

    @shivlaks
    shivlaks committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    49dbaaa View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. Merge branch 'master' into shivlaks/sfn-ecs-tasks

    @shivlaks
    shivlaks committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    23de662 View commit details
    Browse the repository at this point in the history

  2. update sfn.Data -> sfn.JsonPath

    @shivlaks
    shivlaks committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    15693b3 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Niranjan Jayakar <nija@amazon.com>
    @shivlaks
    shivlaks and Niranjan Jayakar committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    9078d97 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2020

  1. move validation into bind method

    @shivlaks
    shivlaks committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    ad4da0d View commit details
    Browse the repository at this point in the history

  2. modify incorrect default doc

    @shivlaks
    shivlaks committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    1525f3e View commit details
    Browse the repository at this point in the history

  3. reorder methods for easier readability

    @shivlaks
    shivlaks committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    3c7e3bb View commit details
    Browse the repository at this point in the history

  4. grab parameters from the bind when rendering task

    @shivlaks
    shivlaks committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    8bfe251 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Niranjan Jayakar <nija@amazon.com>
    @shivlaks
    shivlaks and Niranjan Jayakar committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    bedce79 View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Niranjan Jayakar <nija@amazon.com>
    @shivlaks
    shivlaks and Niranjan Jayakar committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    6323fae View commit details
    Browse the repository at this point in the history

  7. use customer provided security group when supplied

    @shivlaks
    shivlaks committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    e9b10be View commit details
    Browse the repository at this point in the history

  8. Merge branch 'shivlaks/sfn-ecs-tasks' of https://github.com/aws/aws-cdk… 

    … into shivlaks/sfn-ecs-tasks
    @shivlaks
    shivlaks committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    11fe124 View commit details
    Browse the repository at this point in the history

  9. add LaunchTargetBindOptions

    @shivlaks
    shivlaks committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    062ec0b View commit details
    Browse the repository at this point in the history

  10. modify securityGroup to be securityGroups of type ec2.ISecurityGroup[]

    @shivlaks
    shivlaks committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    bae8051 View commit details
    Browse the repository at this point in the history

  11. drop unnecessary Lazy call for task/execution role

    @shivlaks
    shivlaks committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    54baf07 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2020

  1. make platformVersion required as we don't want to box ourselves in by… 

    … defaulting to latest
    @shivlaks
    shivlaks committed Jun 28, 2020
    Configuration menu
    Copy the full SHA
    d660d0c View commit details
    Browse the repository at this point in the history

  2. update docstring

    @shivlaks
    shivlaks committed Jun 28, 2020
    Configuration menu
    Copy the full SHA
    b123be8 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2020

  1. remove errant trailing whitespace

    @shivlaks
    shivlaks committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    f35ec4b View commit details
    Browse the repository at this point in the history

  2. mark renderTask as internal

    @shivlaks
    shivlaks committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    c167ad9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into shivlaks/sfn-ecs-tasks

    @shivlaks
    shivlaks committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    0179875 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2020

  1. add comment to describe behaviour of placement constraints

    @shivlaks
    shivlaks committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    98af020 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into shivlaks/sfn-ecs-tasks

    @mergify
    mergify[bot] committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    f37e936 View commit details
    Browse the repository at this point in the history