fix(ec2): Remove validation of availabilityZone from Volume #9082
Conversation
|
See my comment on the orginal issue #9081 (comment), basically the validation should be removed. |
| @@ -642,7 +641,8 @@ export class Volume extends VolumeBase { | |||
| } | |||
|
|
|||
| protected validateProps(props: VolumeProps) { | |||
| if (!Token.isUnresolved(props.availabilityZone) && !/^[a-z]{2}-[a-z]+-[1-9]+[a-z]$/.test(props.availabilityZone)) { | |||
| // Note: dummy1[a-z] comes from the DUMMY_VPC_PROPS in vpc.ts. This will be encountered on the first run of a fresh app. | |||
There was a problem hiding this comment.
@NetaNir New revision posted that removes the input validation of the AZ entirely.
ddneilson
changed the title
|
Shouldn't this PR include only the removal of validation? |
Yeah, that would be sensible. I removed the extra stuff. Will submit that as a separate PR. |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This fixes an erroneous validation failure of the `availabilityZone` property of the `Volume` construct that occurs during the first run of a fresh application. Fixes: aws#9081 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This fixes an erroneous validation failure of the
availabilityZoneproperty of theVolumeconstruct that occurs during the first run of a fresh application.Fixes: #9081
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license