Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): ability to query runtime information from the cluster #9535

Merged
merged 29 commits into from
Aug 14, 2020

Conversation

iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Aug 8, 2020

Introduce a KubernetesResourceAttribute construct that executes kubectl get commands to fetch runtime information on kubernetes resources.

Resolves #8394

BREAKING CHANGE: cluster.addResource was renamed to cluster.addManifest and KubernetesResource was renamed to KubernetesManifest


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 8, 2020
@iliapolo iliapolo marked this pull request as ready for review August 9, 2020 16:17
@iliapolo iliapolo requested review from eladb and a team August 9, 2020 16:18
packages/@aws-cdk/aws-eks/README.md Show resolved Hide resolved
packages/@aws-cdk/aws-eks/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-eks/README.md Outdated Show resolved Hide resolved
@iliapolo iliapolo requested a review from eladb August 12, 2020 11:57
@eladb eladb added the pr/do-not-merge This PR should not be merged at this time. label Aug 12, 2020
@iliapolo iliapolo removed the pr/do-not-merge This PR should not be merged at this time. label Aug 13, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 14, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 88d9f29
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 14, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4bc8188 into master Aug 14, 2020
@mergify mergify bot deleted the epolon/kubectl-describe branch August 14, 2020 00:29
@pahud
Copy link
Contributor

pahud commented Aug 15, 2020

This is an awesome feature! Thank you @iliapolo !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-eks] reference a value returned through "kubectl get"
4 participants