chore(cli): fix bugs introduced in stack monitor #9830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #9795, I was under the impression that the `DescribeStackEvents` would list events in chronological order. This was a misunderstanding resulting from not reading the documentation-- in fact, the events are returned in reverse chronological order. The paging logic was therefore wrong and the events would be fed into the activity printer in the wrong order, leading to incorrect progress reporting. This is a critical bug and must be fixed immediately! While I was in there, fixed two other paper cuts around the printer at the same time: - Events occurring near the start of the monitor would be missed. This was because time-based filtering would be employed based on the client machine's local clock, which might be out of sync with the remote clock. Use the server's clock instead, by using the `CreationTime` of the ChangeSet as the start time. - Events occurring near the end of the monitor would be missed. This was because `DescribeStackStatus` might return a completion state before the monitor had polled the events that led up to the completion. Fix by doing a final poll after the stop call has been received, so we are guaranteed to have seen all events.
skinny85
approved these changes
Aug 19, 2020
| @@ -83,7 +96,7 @@ export class StackActivityMonitor { | |||
| /** | |||
| * Determines which events not to display | |||
| */ | |||
| private startTime = Date.now(); | |||
| private readonly startTime: number; | |||
There was a problem hiding this comment.
Any reason not to leave this as a Date?
There was a problem hiding this comment.
Just simpler implementation, and since it doesn't affect the public API I prefer this.
shivlaks
approved these changes
Aug 19, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #9795, I was under the impression that the
DescribeStackEventswould list events in chronological order.
This was a misunderstanding resulting from not reading the documentation--
in fact, the events are returned in reverse chronological order.
The paging logic was therefore wrong and the events would be fed into
the activity printer in the wrong order, leading to incorrect progress
reporting.
This is a critical bug and must be fixed immediately!
While I was in there, fixed two other paper cuts around the
printer at the same time:
Events occurring near the start of the monitor would be missed. This
was because time-based filtering would be employed based on the
client machine's local clock, which might be out of sync with the
remote clock. Use the server's clock instead, by using the
CreationTimeof the ChangeSet as the start time.Events occurring near the end of the monitor would be missed. This
was because
DescribeStackStatusmight return a completion statebefore the monitor had polled the events that led up to the completion.
Fix by doing a final poll after the stop call has been received,
so we are guaranteed to have seen all events.
The actual claim in that PR was incorrect. We were not quadratic (we
wouldn't list all pages on every tick), we were just more linear than
necessary (we would list all pages on the first tick... which is still
a lot). The current PR properly fixes the issue by stopping paging
not just if we've already seen the events, but also if the events are
starting to fall outside the time window we are interested in.
This actually fixes #9470.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license