Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --rollback-configuration to cloudformation deploy #3712

Closed
jaakkotuosa opened this issue Nov 9, 2018 · 25 comments
Closed

Add --rollback-configuration to cloudformation deploy #3712

jaakkotuosa opened this issue Nov 9, 2018 · 25 comments
Assignees
@tim-finnigan
Labels
closing-soon This issue will automatically close in 4 days unless further comments are made. cloudformation package-deploy customization Issues related to CLI customizations (located in /awscli/customizations) feature-request A feature should be added or improved. help wanted We are asking the community to submit a PR to resolve this issue.

Comments

@jaakkotuosa
Copy link

I think cloudformation deploy should have --rollback-configuration just like create-stack and update-stack.
@justnance justnance self-assigned this Nov 9, 2018
@justnance
Copy link

@jaakkotuosa - Thank you for reaching out. I am labeling this issue as a feature request pending further review. Please review the Rollback Configuration for our other SDKs and advise if this is how you'd like the feature to work.

@sanathkr - what are your thoughts?

@justnance justnance added cloudformation package-deploy feature-request A feature should be added or improved. labels Nov 9, 2018
@sanathkr
Copy link
Contributor

Good idea! Should be a feature request. Happy to take PRs for this.

@max-allan-surevine
Copy link

I think it needs --disable-rollback as well as --rollback-configuration !

@justnance
Copy link

@max-allan-surevine - Thanks adding feedback. Both are good ideas.

@justnance justnance added the help wanted We are asking the community to submit a PR to resolve this issue. label Jan 28, 2019
@dnascimento
Copy link

@justnance Could AWS prioritise it?

@ozbillwang
Copy link

ozbillwang commented Jul 19, 2019 •
edited
Loading

@justnance

I am waiting for this feature as well, it should be three options and same as create-stack.

[--disable-rollback | --no-disable-rollback]
[--rollback-configuration ]

And add [--disable-rollback | --no-disable-rollback] should be quicker and first to be implemented.

The reason why we need this option is, with two commands create-stack and update-stack, we can manage the cloudformation stack, but it is not convenience.

With only one command deploy, we can deploy a new stack or update an exist stack.

Any progress on this feature?

By the way, could you give some hints on which files will be updated in this feature? I did search the sample about create-stack, but no luck.

@justnance
Copy link

There is no ETA or update yet. PRs are welcome.

@citrusoft
Copy link

another vote for this feature as it facilitates root-cause-analysis of failed pipelines of failed stacks.

@emmahyde
Copy link

emmahyde commented Jun 8, 2020

I attempted to create a PR for this, but it appears the create_change_set API client functionality does not support this. What can we do, as a community, to encourage that this be included in the API?

@max-allan-surevine
Copy link

I attempted to create a PR for this, but it appears the create_change_set API client functionality does not support this. What can we do, as a community, to encourage that this be included in the API?

https://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_CreateChangeSet.html
Says :

RollbackConfiguration
The rollback triggers for AWS CloudFormation to monitor during stack creation and updating operations, and for the specified monitoring period afterwards.
Type: RollbackConfiguration object
Required: No

Same as on create stack :

RollbackConfiguration
The rollback triggers for AWS CloudFormation to monitor during stack creation and updating operations, and for the specified monitoring period afterwards.
Type: RollbackConfiguration object
Required: No

The change set does lack disable-rollback though. On creation and execution, which is weird!

@brosaaj
Copy link

brosaaj commented Oct 21, 2020

Any updates on that? Need this feature badly

@kdaily kdaily added the customization Issues related to CLI customizations (located in /awscli/customizations) label Nov 12, 2020
@ezeev
Copy link

ezeev commented Apr 2, 2021

+1 - what is the status of this?

@NickTheSecurityDude
Copy link

+1

3 similar comments
@sp0f
Copy link

sp0f commented May 10, 2021

+1

@mjacobsson
Copy link

+1

@martini631
Copy link

+1

@cdion3537
Copy link

Guys, what's the update here? Over two years and nothing? No wonder everyone is going to Terraform.

@alrawas
Copy link

alrawas commented Jul 30, 2021

:(

@atheiman
Copy link
Contributor

atheiman commented Oct 6, 2021

To simplify this issue and match other cloudformation cli commands, I think the option could just be -–disable-rollback. This option already exists in create-stack, update-stack, and execute-change-set

atheiman added a commit to atheiman/aws-cli that referenced this issue Oct 6, 2021
@atheiman
aws#3712 add --disable-rollback to aws cloudformation deploy
ad6e728
@atheiman atheiman mentioned this issue Oct 6, 2021
Merged
@atheiman
Copy link
Contributor

atheiman commented Oct 6, 2021 •
edited
Loading

I've started a PR for this #6453 which adds --disable-rollback | --no-disable-rollback to aws cloudformation deploy. This option is already on create-stack, update-stack, and execute-change-set, so I think it makes sense to have on deploy. Its a simpler interface to disabling rollback, which is what I think most people would use --rollback-configuration for. Need to test it locally / polish it up and get a review from a maintainer still.

@tim-finnigan tim-finnigan added the needs-review This issue or pull request needs review from a core team member. label Oct 6, 2021
atheiman added a commit to atheiman/aws-cli that referenced this issue Nov 5, 2021
@atheiman
aws#3712 add --disable-rollback to aws cloudformation deploy
9ecba5f
stealthycoin pushed a commit to atheiman/aws-cli that referenced this issue Feb 4, 2022
@atheiman @stealthycoin
aws#3712 add --disable-rollback to aws cloudformation deploy
4965818
aws-sdk-python-automation added a commit that referenced this issue Feb 4, 2022
@aws-sdk-python-automation
Merge branch 'release-1.22.49'
b1e8878 
* release-1.22.49:
  Bumping version to 1.22.49
  Update changelog based on model updates
  fix unit tests
  doc updates
  wording changes, deploy(... disable_rollback=False ...), disable_rollback added to docstring
  #3712 add --disable-rollback to `aws cloudformation deploy`
@tim-finnigan tim-finnigan self-assigned this Jun 9, 2022
@tim-finnigan tim-finnigan removed the needs-review This issue or pull request needs review from a core team member. label Jun 9, 2022
@tim-finnigan
Copy link
Contributor

Since #6453 was merged I think we can close this issue. As mentioned in the comment above, that PR didn't add --rollback-configuration but added a disable rollback option which is likely what most people needed. If anyone has additional feedback to share please let us know, otherwise I will set this to close if we don't get any responses.

@tim-finnigan tim-finnigan added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jun 9, 2022
@ozbillwang
Copy link

Good job, which aws cli version I can run a test with?

@atheiman
Copy link
Contributor

If I remember right, —disable-rollback has been released, so you can just pull the latest aws cli v2. You can confirm you have it by running aws cloudformation deploy help and see if the flag is in the help output.

@tim-finnigan
Copy link
Contributor

Thanks @atheiman! I'll go ahead and close this. If further enhancements beyond that PR are requested then I think it would be better to track those in a new issue.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

@Xiphe Xiphe mentioned this issue Sep 8, 2022
Open
2 tasks
ConnorKirk pushed a commit to ConnorKirk/aws-cli that referenced this issue Oct 28, 2022
@atheiman @ConnorKirk
aws#3712 add --disable-rollback to aws cloudformation deploy
7c78a02
godd9170 pushed a commit to godd9170/aws-cli that referenced this issue Mar 7, 2023
@atheiman @godd9170
aws#3712 add --disable-rollback to aws cloudformation deploy
574e093
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tim-finnigan tim-finnigan

Labels
closing-soon This issue will automatically close in 4 days unless further comments are made. cloudformation package-deploy customization Issues related to CLI customizations (located in /awscli/customizations) feature-request A feature should be added or improved. help wanted We are asking the community to submit a PR to resolve this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests