Fix issue with network interfaces #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some customizations for ec2 run instances that used the NetworkInterfaces parameter but did not lower some of the legacy parameters to the NetworkInterfaces param causing server side validation errors.
|
Fixes #613 as well |
|
⛵ |
|
|
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some customizations for ec2 run instances that used the NetworkInterfaces parameter but did not lower some of the legacy parameters to the NetworkInterfaces param causing server side validation errors.
If you do not do this, you get errors like this:
There is even a note about this: https://github.com/aws/aws-cli/blob/develop/awscli/customizations/ec2runinstances.py#L83 so it looks like these parameters just got missed because it now works for me.
cc @jamesls @JordonPhillips