-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When printing options in two or more columns, sort them so they read naturally #3211
Conversation
…naturally within a column.
Codecov Report
@@ Coverage Diff @@
## develop #3211 +/- ##
===========================================
+ Coverage 97.11% 97.11% +<.01%
===========================================
Files 407 407
Lines 33530 33539 +9
===========================================
+ Hits 32563 32572 +9
Misses 967 967
Continue to review full report at Codecov.
|
Anyone able to review this and comment on it? |
@JordonPhillips - we chatted at pycon about this :) |
Hi @scotwk, thanks for the contribution! Our team just put out a recent proposal in #6828 detailing improvements to the contribution process. We are working through open PRs and are trying to determine where this issue falls. For feature requests, to invest the time in reviewing it, we would like to make sure the feature has wider community interest and are looking for 10 👍 votes on the issue #6974. In the meantime, we are going to set this PR as a draft. Once the 👍 threshold is met, we will move this PR to the “Implementation” stage and take a closer look. |
Thank you for creating this PR. I'm checking in as there hasn't been any activity here for a while. Now that CLI auto-prompt mode is available, you can see a list of services/commands in alphabetical order before encountering the help message. If folks would still like to see this feature, we can continue tracking the request in #6974. But for the feature to be implemented the PR would have to account for changes in the |
When printing options in the help message the options are sorted so they read row by row. E.g.:
But that's not how we naturally read columns of text. It should be sorted so we read one column, then the next. E.g.:
This commit implements the latter sorting behavior. It will work for differing values of
ChoicesPerLine
in case that gets changed.