Adds --size-only param to aws s3 sync to allow syncing by filesize only.
#719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnboxall
changed the title
--size-only param to aws s3 sync--size-only param to aws s3 sync to allow syncing by filesize only.
|
Thanks, this looks good to me. I think we should just add one more test, for when src_time > dst_time and sizes are equal. |
|
@jamesls I've added the suggested test in my new commit. I've opted for the non-DRY style here as it seems to be the pattern set by the rest of the tests in |
|
@johnboxall Thanks for the pull request, I think it looks great. Sorry for the delay. I've been asked to obtain a signed CLA for this contribution. Would you mind emailing me at the address in my github profile so I can send you the CLA. Thanks. |
jamesls
added a commit
that referenced
this pull request
Apr 4, 2014
|
Merged, thanks again for the contribution. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based heavily off #575, implements the
--size-onlyparam as discussed in #473 and #599.