Fix issue with shadowed max-items arguments #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we add pagination configs for a service, we hide the original manual pagination arguments in favor of the normalized arguments. However, to support backwards compatability we still allow users to specify the manual arguments. If we detect this is the case we will turn off pagination. However, when the normalized argument matches the manual paging argument (as is the case when a service users `MaxItems`), we have an ambiguous case. Did they mean the back-compat version of the normalized argument version? Previously we were assuming the user meant the manual paging argument. Now we assume that they meant the normalized paging arguments. Services impacted: * route53 * iam * ses
We don't pass max-items anymore.
|
I've fixed the failing test . @danielgtaylor mind taking a look? |
|
LGTM 🚢-it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we add pagination configs for a service, we hide
the original manual pagination arguments in favor of the normalized
arguments. However, to support backwards compatability we still
allow users to specify the manual arguments. If we detect this is the
case we will turn off pagination.
However, when the normalized argument matches the manual paging argument
(as is the case when a service users
MaxItems), we have an ambiguouscase. Did they mean the back-compat version of the normalized argument
version? Previously we were assuming the user meant the manual paging
argument. Now we assume that they meant the normalized paging
arguments.
Services impacted: