chore: Update the version of Amazon.CDK.Lib that is referenced by the recipe CDK projects #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… recipe CDK projects
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #818 +/- ##
===========================================
+ Coverage 32.34% 61.45% +29.11%
===========================================
Files 271 277 +6
Lines 10604 10659 +55
Branches 1474 1484 +10
===========================================
+ Hits 3430 6551 +3121
+ Misses 6885 3568 -3317
- Partials 289 540 +251 ☔ View full report in Codecov by Sentry. |
ashovlin
changed the title
philasmar
approved these changes
Mar 14, 2024
… log S3 bucket when creating a new bucket for the Blazor WebAssembly App recipe
ashovlin
commented
Mar 20, 2024
| @@ -132,6 +132,7 @@ private void ConfigureCloudFrontDistribution(Configuration settings) | |||
| var loggingBucket = new Bucket(this, nameof(AccessLoggingBucket), InvokeCustomizeCDKPropsEvent(nameof(AccessLoggingBucket), this, new BucketProps | |||
| { | |||
| RemovalPolicy = RemovalPolicy.RETAIN, | |||
| AccessControl = BucketAccessControl.LOG_DELIVERY_WRITE | |||
There was a problem hiding this comment.
Unrelated to the CDK version, noticed that this is failing as well due to a change in S3 behavior last year. See aws/aws-cdk#27571 for more info.
|
I've manually tested that deploying an application using 1.18.6 (currently live), and then redeploying with this branch works for the Fargate and App Runner recipes. I'm struggling to redeploy a Beanstalk application with 1.18.6 both before and after, but don't think it'd be related to this change. |
normj
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Our integration tests began failing for the Blazor recipe:
By setting
AutoDeleteObjectson the S3 bucket in the recipe to true, a CDK-defined Node 14 Lambda is deployed (which is no longer supported as of 1/19/24):aws-dotnet-deploy/src/AWS.Deploy.Recipes/CdkTemplates/BlazorWasm/Generated/Recipe.cs
Line 57 in 5505e40
This updates the
Amazon.CDK.Libfor all of the recipes to the latest. I believe they went to Node 18 for custom resources in 2.87 via aws/aws-cdk#26212.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.