Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update the version of Amazon.CDK.Lib that is referenced by the recipe CDK projects #818

Merged
merged 3 commits into from Mar 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion THIRD_PARTY_LICENSES
Expand Up @@ -21,7 +21,7 @@
** AWSSDK.ElasticLoadBalancingV2; version 3.7.201.27 -- https://www.nuget.org/packages/AWSSDK.ElasticLoadBalancingV2/
** AWSSDK.Core; version 3.7.202.11 -- https://www.nuget.org/packages/AWSSDK.Core
** AWSSDK.CloudWatchLogs; version 3.7.200.42 -- https://www.nuget.org/packages/AWSSDK.CloudWatchLogs
** Amazon.CDK.Lib; version 2.43.1 -- https://www.nuget.org/packages/Amazon.CDK.Lib/
** Amazon.CDK.Lib; version 2.131.0 -- https://www.nuget.org/packages/Amazon.CDK.Lib/

Apache License
Version 2.0, January 2004
Expand Down
Expand Up @@ -13,7 +13,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Amazon.CDK.Lib" Version="2.43.1" />
<PackageReference Include="Amazon.CDK.Lib" Version="2.131.0" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="6.0.0" />
</ItemGroup>

Expand Down
Expand Up @@ -24,7 +24,7 @@

<ItemGroup>
<!-- CDK Construct Library dependencies -->
<PackageReference Include="Amazon.CDK.Lib" Version="2.43.1" />
<PackageReference Include="Amazon.CDK.Lib" Version="2.131.0" />

<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="6.0.0" />

Expand Down
Expand Up @@ -25,7 +25,7 @@

<ItemGroup>
<!-- CDK Construct Library dependencies -->
<PackageReference Include="Amazon.CDK.Lib" Version="2.43.1" />
<PackageReference Include="Amazon.CDK.Lib" Version="2.131.0" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="6.0.0" />

<!-- jsii Roslyn analyzers (un-comment to obtain compile-time checks for missing required props
Expand Down
Expand Up @@ -25,7 +25,7 @@

<ItemGroup>
<!-- CDK Construct Library dependencies -->
<PackageReference Include="Amazon.CDK.Lib" Version="2.43.1" />
<PackageReference Include="Amazon.CDK.Lib" Version="2.131.0" />

<PackageReference Include="AWSSDK.ElasticBeanstalk" Version="3.7.200.42" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="6.0.0" />
Expand Down
Expand Up @@ -193,7 +193,7 @@ private string ConfigureApplication(Configuration settings)
ApplicationName = beanstalkApplicationName
}));

ApplicationVersion.AddDependsOn(BeanstalkApplication);
ApplicationVersion.AddDependency(BeanstalkApplication);
}

return beanstalkApplicationName;
Expand Down
Expand Up @@ -25,7 +25,7 @@

<ItemGroup>
<!-- CDK Construct Library dependencies -->
<PackageReference Include="Amazon.CDK.Lib" Version="2.43.1" />
<PackageReference Include="Amazon.CDK.Lib" Version="2.131.0" />

<PackageReference Include="AWSSDK.ElasticBeanstalk" Version="3.7.200.42" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="6.0.0" />
Expand Down
Expand Up @@ -193,7 +193,7 @@ private string ConfigureApplication(Configuration settings)
ApplicationName = beanstalkApplicationName
}));

ApplicationVersion.AddDependsOn(BeanstalkApplication);
ApplicationVersion.AddDependency(BeanstalkApplication);
}

return beanstalkApplicationName;
Expand Down
Expand Up @@ -25,7 +25,7 @@

<ItemGroup>
<!-- CDK Construct Library dependencies -->
<PackageReference Include="Amazon.CDK.Lib" Version="2.43.1" />
<PackageReference Include="Amazon.CDK.Lib" Version="2.131.0" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="6.0.0" />

<!-- jsii Roslyn analyzers (un-comment to obtain compile-time checks for missing required props
Expand Down
Expand Up @@ -132,6 +132,7 @@ private void ConfigureCloudFrontDistribution(Configuration settings)
var loggingBucket = new Bucket(this, nameof(AccessLoggingBucket), InvokeCustomizeCDKPropsEvent(nameof(AccessLoggingBucket), this, new BucketProps
{
RemovalPolicy = RemovalPolicy.RETAIN,
AccessControl = BucketAccessControl.LOG_DELIVERY_WRITE
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the CDK version, noticed that this is failing as well due to a change in S3 behavior last year. See aws/aws-cdk#27571 for more info.

}));

distributionProps.LogBucket = loggingBucket;
Expand Down
Expand Up @@ -25,7 +25,7 @@

<ItemGroup>
<!-- CDK Construct Library dependencies -->
<PackageReference Include="Amazon.CDK.Lib" Version="2.43.1" />
<PackageReference Include="Amazon.CDK.Lib" Version="2.131.0" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="6.0.0" />

<!-- jsii Roslyn analyzers (un-comment to obtain compile-time checks for missing required props
Expand Down
Expand Up @@ -25,7 +25,7 @@

<ItemGroup>
<!-- CDK Construct Library dependencies -->
<PackageReference Include="Amazon.CDK.Lib" Version="2.43.1" />
<PackageReference Include="Amazon.CDK.Lib" Version="2.131.0" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="6.0.0" />

<!-- jsii Roslyn analyzers (un-comment to obtain compile-time checks for missing required props
Expand Down