deploy-serverless breaks Swagger definitions in yaml #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…then reserializing causes unintended side effects
|
Thanks for the pull request. I have merged the pull request in the dev branch. I'll get it included with the next release. |
|
Version 2.1.4 was released with this pull request. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-lambda-dotnet#265
deploy-serverless breaks Swagger definitions in yaml
Description of changes:
Changed LambdaUtilities.UpdateCodeLocationInYamlTemplate
Deserializing the file into a dynamic object, updating the object, and then reserializing the object had unintended side effects that broke when there were swagger definitions and some intrinsic functions
Instead this code parses the file, removes any existing definitions of the code location, and then adds the location defined by the parameters passed into the function.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.