Minor performance improvements to Amazon.Lambda.RuntimeSupport #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normj
force-pushed
the
norm/perf-work-lambdabootstrap
branch
from
1486703
to
ed2f8e2
Compare
ganeshnj
reviewed
Feb 1, 2022
| bool doStartInvokeLoop = _initializer == null || await InitializeAsync(); | ||
|
|
||
| while (doStartInvokeLoop && !cancellationToken.IsCancellationRequested) | ||
| { | ||
| try | ||
| { | ||
| await InvokeOnceAsync(cancellationToken); | ||
| if(runOnce) | ||
| { | ||
| return; |
There was a problem hiding this comment.
We should do some logging that Lambda is configured for run once and process is exiting for diagnostics.
There was a problem hiding this comment.
Good idea, I have added the messaging.
normj
force-pushed
the
norm/perf-work-lambdabootstrap
branch
from
ed2f8e2
to
80eefeb
Compare
ganeshnj
approved these changes
Feb 1, 2022
carlzogh
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Minor tweaks while profiling Amazon.Lambda.RuntimeSupport to reduce time spent in this package during coldstarts. I would have liked to do more style/whitespace cleanup to
InternalClientAdaptedbut I don't want the logic changes to be unnoticeable in a file with all lines changed.LAMBDA_RUNTIMESUPPORT_DEBUGenvironment variable is set.InternalClientAdaptedError2Asyncmethod since this was replaced in previous PR withErrorWithXRayCauseAsyncAWS_LAMBDA_DOTNET_DEBUG_RUN_ONCEenvironment variable for local profiling so process terminates cleanly after processing a single event. This environment variable should never be set when deployed to Lambda.SocketsHttpHandlerfor the HttpClient to avoid the HttpClient creating an additional wrapper handlerHttpClientHandler.InternalClientAdapted.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.