#1300 ASP.NET Core Server Custom Serializer #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normj
requested changes
Oct 20, 2022
| /// <param name="eventSource"></param> | ||
| /// <param name="serializer"></param> | ||
| /// <returns></returns> | ||
| public static IServiceCollection AddAWSLambdaHosting(this IServiceCollection services, LambdaEventSource eventSource, ILambdaSerializer serializer) |
There was a problem hiding this comment.
Instead of using a static place holder I think it would be more idiomatic to have this method that takes in an action callback that can be used for configuing.
Something like
public static IServiceCollection AddAWSLambdaHosting(this IServiceCollection services, LambdaEventSource eventSource, ILambdaSerializer serializer, Action<HostingOptions> configure = null)
{
var options = new HostingOptions();
if(configure != null) configure.Invoke(options);
...
var serializer = options.Serializer ?? new DefaultLambdaJsonSerializer();
...
}
There was a problem hiding this comment.
@normj code updated, I've added an integration test as well. I think I understood the integration test framework correctly and they pass on my machine. Let me know if you want any more changes.
normj
requested changes
Nov 20, 2022
Libraries/src/Amazon.Lambda.AspNetCoreServer/Internal/Utilities.cs
Outdated
Show resolved
Hide resolved
Libraries/src/Amazon.Lambda.AspNetCoreServer.Hosting/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
Libraries/src/Amazon.Lambda.AspNetCoreServer/Internal/HostingOptions.cs
Outdated
Show resolved
Hide resolved
normj
approved these changes
Dec 8, 2022
|
I ended up doing some slight tweaks to the PR before finishing the merge. 872b510 |
|
PR has been released as part of version 1.5.0 of Amazon.Lambda.AspNetCoreServer.Hosting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1300
Allow the AspNetCoreServer.Hosting package to use a user provided serializer.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.