Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier support for application/x-protobuf with lambda functions #1599

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

yuriygavriluk
Copy link
Contributor

Issue #, if available:

application/x-protobuf is binary format, thus always to be base64 encoded.
with this code people who use it in lambdas will not have to manually add this encoding

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@normj normj changed the base branch from master to dev October 27, 2023 18:57
@normj normj changed the base branch from dev to master October 27, 2023 18:57
@normj normj changed the base branch from master to dev October 27, 2023 18:58
Copy link
Member

@normj normj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@eddiemcs3 eddiemcs3 self-requested a review October 31, 2023 12:41
@yuriygavriluk
Copy link
Contributor Author

Not too sure why it is failing
'Credentials could not be loaded, please check your action inputs: Could not load credentials from any providers'

@eddiemcs3
Copy link

This is on our side and will not be an issue. This should get in shortly.

@normj normj merged commit ca4289d into aws:dev Oct 31, 2023
2 of 3 checks passed
@normj
Copy link
Member

normj commented Nov 14, 2023

The PR has been released as part of version 8.1.1 of Amazon.Lambda.AspNetCoreServer. Thanks again for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants