Contract resolvers are stateless. Reuse them #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normj
approved these changes
Sep 20, 2019
|
Version 1.7.0 of Amazon.Lambda.Serialization.Json has been released with this PR. |
|
Nice. Less allocations in AWS makes us all happy campers 😁👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContractResolvers are stateless and can be reused.
Decided to use the AwsResolver as the root object for the converters and use a simple pattern to initialize the fields once
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.