Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dmarcVerdict to the SimpleEmailReceipt #100

Merged
merged 3 commits into from
Aug 1, 2018

Conversation

jmoney
Copy link
Contributor

@jmoney jmoney commented Jul 27, 2018

dmarcVerdict seems to be missing from the SimpleEmailReceipt struct. This adds it in.

dmarcVerdict seems to be missing from the SimpleEmailReceipt struct.  This adds it in.
@jmoney
Copy link
Contributor Author

jmoney commented Jul 28, 2018

I'm actually unsure why this build is failing. I cannot find the error message in travis. Running the test command locally seems to be working fine.

@jmoney
Copy link
Contributor Author

jmoney commented Jul 28, 2018

I'd love some pointers on where to find this so I can fix the test

@codecov-io
Copy link

codecov-io commented Jul 28, 2018

Codecov Report

Merging #100 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   71.34%   71.34%           
=======================================
  Files          17       17           
  Lines         698      698           
=======================================
  Hits          498      498           
  Misses        156      156           
  Partials       44       44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7af112...282fa3f. Read the comment docs.

@jmoney
Copy link
Contributor Author

jmoney commented Jul 28, 2018

Got it fixed. 💪

@bmoffatt bmoffatt merged commit 1a8f6e5 into aws:master Aug 1, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants