Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-lc-sys to v0.20.0 #455

Merged
merged 24 commits into from
Jul 15, 2024
Merged

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Jul 3, 2024

Issues

Addresses:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner July 3, 2024 14:25
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.83%. Comparing base (c358484) to head (51289b0).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
- Coverage   95.80%   92.83%   -2.97%     
==========================================
  Files          61       62       +1     
  Lines        8143     8626     +483     
  Branches        0     8626    +8626     
==========================================
+ Hits         7801     8008     +207     
- Misses        342      362      +20     
- Partials        0      256     +256     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth marked this pull request as draft July 11, 2024 14:49
@justsmth justsmth changed the title Update aws-lc-sys to v0.20.0 [DRAFT] Update aws-lc-sys to v0.20.0 Jul 11, 2024
@justsmth
Copy link
Contributor Author

I plan to re-align this aws-lc-sys v0.20.0 release with the upcoming AWS-LC 1.32.0 release, which should have fixes for both #453 and #427.

@justsmth justsmth force-pushed the generate/aws-lc-sys-v0.20.0 branch from 0f9054d to 51289b0 Compare July 15, 2024 16:54
@justsmth justsmth changed the title [DRAFT] Update aws-lc-sys to v0.20.0 Update aws-lc-sys to v0.20.0 Jul 15, 2024
@justsmth justsmth marked this pull request as ready for review July 15, 2024 16:55
@justsmth justsmth requested a review from skmcgrail July 15, 2024 16:56
Copy link

@WillChilds-Klein WillChilds-Klein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per guidance from @justsmth , i only reviewed the 2 commits authored by him.

@justsmth justsmth merged commit 4b9bd34 into aws:main Jul 15, 2024
182 of 190 checks passed
@justsmth justsmth deleted the generate/aws-lc-sys-v0.20.0 branch July 15, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants