Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging step for aws-logging-dotnet #142

Merged
merged 4 commits into from
Dec 9, 2020
Merged

Fix packaging step for aws-logging-dotnet #142

merged 4 commits into from
Dec 9, 2020

Conversation

SrutiG
Copy link
Contributor

@SrutiG SrutiG commented Nov 3, 2020

Issue #, if available:
None

Description of changes:
When running the packaging step in the aws-logging-dotnet pipeline, I encountered the following errors:

C:\Program Files\dotnet\sdk\3.1.402\Sdks\NuGet.Build.Tasks.Pack\buildCrossTargeting\NuGet.Build.Tasks.Pack.targets(198,5): error NU5125: The 'licenseUrl' element will be deprecated. Consider using the 'license' element instead. [C:\codebuild\tmp\output\src371779675\src\src\AWS.Logger.Core\AWS.Logger.Core.csproj]
--
47 | C:\Program Files\dotnet\sdk\3.1.402\Sdks\NuGet.Build.Tasks.Pack\buildCrossTargeting\NuGet.Build.Tasks.Pack.targets(198,5): error NU5048: The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl

I encountered these errors as well when running it locally.

I fixed the PackageLicenseUrl issue by switching it to PackageLicenseExpression. Switching the PackageIconUrl to PackageIcon requires adding the image to the repository. I suppressed the error for now.

EDIT (11/9): Referenced local LICENSE file using PackageLicenseFile and added icon.png and added PackageIcon reference

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@normj normj merged commit 5297ab5 into master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants