Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify meaning filename that it also may contain path. #248

Merged
merged 3 commits into from
May 10, 2024

Conversation

monty241
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashovlin ashovlin self-requested a review April 18, 2024 20:56
Copy link
Member

@ashovlin ashovlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the equivalent string on the library-specific configs?

For example, here for Log4net:

/// <summary>
/// Gets and sets the LibraryLogFileName property. This is the name of the file into which errors from the AWS.Logger.Core library will be written into.
/// <para>
/// The default is going to "aws-logger-errors.txt".
/// </para>
/// </summary>
public string LibraryLogFileName

@ashovlin ashovlin changed the base branch from master to dev May 3, 2024 20:44
@ashishdhingra ashishdhingra merged commit 88291cc into aws:dev May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants