Fix metrics logging error; Remove version log #168
Conversation
| @@ -56,11 +55,6 @@ func init() { | |||
|
|
|||
| func main() { | |||
| initLogger, _ := getLoggerWithLogLevel("info", "") | |||
| initLogger.Info("version", | |||
| "GitVersion", version.GitVersion, | |||
There was a problem hiding this comment.
Yeah we never rebuild the same tag so just the tag should be sufficient to identify the commit..
| @@ -135,6 +129,6 @@ func loadControllerConfig() (config.ControllerConfig, error) { | |||
|
|
|||
| // getLoggerWithLogLevel returns logger with specific log level. | |||
| func getLoggerWithLogLevel(logLevel string, logFilePath string) (logr.Logger, error) { | |||
| ctrlLogger := logger.New(logLevel, logFilePath) | |||
| ctrlLogger := logger.New(logLevel, logFilePath, 2) | |||
There was a problem hiding this comment.
Nit: later we can move the logger defaults of 0,1,2..to utils as enum
There was a problem hiding this comment.
Yeah, I considered an enum, but could not come up with any names that make sense, as the value to use is dependent on where the logger will be called from. If you are within a goroutine function, you want 0, as above is the standard library runtime. If you are within the controller handle routines, you want 2, as you want to skip the controller call stack surrounding the function
| @@ -43,3 +45,8 @@ func setupMetricsServer() *http.Server { | |||
| } | |||
| return server | |||
| } | |||
|
|
|||
| func getMetricsLogger() logr.Logger { | |||
| ctrlLogger := logger.New("info", "", 0) | |||
There was a problem hiding this comment.
Nit: Same as above..this can be a util enum..but can take it up as followup..
Issue #, if available:
#103
#49
Description of changes:
This PR fixes two issues:
New log looks like:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.