Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more gh actions improvements #420

Merged
merged 10 commits into from
May 22, 2024
Merged

more gh actions improvements #420

merged 10 commits into from
May 22, 2024

Commits on May 21, 2024

  1. ci(github): fix: take actionlint fixes 

    + protect against quoting issues in shell expansion.

+ Fix logic error with unnecessary ${{}} usage.

> This step was not conditionally executed prior to this commit.
> > "[the condition] is always evaluated to true because extra characters
> > are around ${{ }}"

See https://github.com/rhysd/actionlint/blob/main/docs/checks.md for
details.
    @aws-nslick
    aws-nslick committed May 21, 2024
    Configuration menu
    Copy the full SHA
    a0df31a View commit details
    Browse the repository at this point in the history

  2. ci(github): distcheck: use github cache 

    use the gh actions cache for apt packages, rather than redownloading
them every time. This should accelerate the build somewhat. May need to
tweak this in the future and/or move these actions to codebuild runners
to avoid hitting cache limit.
    @aws-nslick
    aws-nslick committed May 21, 2024
    Configuration menu
    Copy the full SHA
    09f5b09 View commit details
    Browse the repository at this point in the history

  3. ci(github): rename config.log artifacts 

    Uploading the artifact with only matrix.cc in the name can cause
collisions when both fail. Upload it as
 `${{ matrix.cc }}-${{ matrix.sdk}}-config.log'
instead so that it is unique.
    @aws-nslick
    aws-nslick committed May 21, 2024
    Configuration menu
    Copy the full SHA
    cbcc93d View commit details
    Browse the repository at this point in the history

  4. ci(github): expand matrix for latest cc 

    Install and build with both the default version of the compiler in the
repos, as well as the latest available via either the ubuntu toolchain
team gcc builds, or the llvm apt repos.
    @aws-nslick
    aws-nslick committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f93aa7e View commit details
    Browse the repository at this point in the history

  5. ci(github): ubuntu: re-enable fail-fast 

    With more elements in the test matrix, fail-fast helps shift left.
Rather than seeing 4-5 different failures, just stop immediately with
the error message responsible.
    @aws-nslick
    aws-nslick committed May 21, 2024
    Configuration menu
    Copy the full SHA
    bb04814 View commit details
    Browse the repository at this point in the history

  6. ci(github): add concurrency block 

    on eg: force pushes while a job is still running, make the start of the
new job cancel the old job. head_ref is undefined on non-pull_request
runs per their docs.
    @aws-nslick
    aws-nslick committed May 21, 2024
    Configuration menu
    Copy the full SHA
    e31df75 View commit details
    Browse the repository at this point in the history

  7. ci(github): add a configuration file for codechecker 

    + ignore unit tests
+ disable unused parameter warnings.
    @aws-nslick
    aws-nslick committed May 21, 2024
    Configuration menu
    Copy the full SHA
    7e610e6 View commit details
    Browse the repository at this point in the history

  8. ci(github): split codechecker to separate job 

    Move codechecker to its own job, gated but the success of the
distbuilds.
    @aws-nslick
    aws-nslick committed May 21, 2024
    Configuration menu
    Copy the full SHA
    3ab5724 View commit details
    Browse the repository at this point in the history

  9. ci(github): add an lttng build 

    lttng defaults to on, so nothing is required other than installing it
conditionally. Add a build for it.
    @aws-nslick
    aws-nslick committed May 21, 2024
    Configuration menu
    Copy the full SHA
    266eb8a View commit details
    Browse the repository at this point in the history

  10. ci(github): add an al2023 build 

    Add an al2023 build (aws#282), alongside the recently added al2 build. This
also runs on codebuild "self-hosted" runners rather than on the gh
hosted runners. To avoid installing the full toolkit, disable tests in
that build (see related commit b9c46d2).
    @aws-nslick
    aws-nslick committed May 21, 2024
    Configuration menu
    Copy the full SHA
    504b37f View commit details
    Browse the repository at this point in the history