more gh actions improvements #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-nslick
force-pushed
the
gh-actions-faster
branch
3 times, most recently
from
15ce4d1
to
b5d5d0e
Compare
aws-nslick
force-pushed
the
gh-actions-faster
branch
10 times, most recently
from
b0a914b
to
7af9a32
Compare
+ protect against quoting issues in shell expansion.
+ Fix logic error with unnecessary ${{}} usage.
> This step was not conditionally executed prior to this commit.
> > "[the condition] is always evaluated to true because extra characters
> > are around ${{ }}"
See https://github.com/rhysd/actionlint/blob/main/docs/checks.md for
details.
use the gh actions cache for apt packages, rather than redownloading them every time. This should accelerate the build somewhat. May need to tweak this in the future and/or move these actions to codebuild runners to avoid hitting cache limit.
Uploading the artifact with only matrix.cc in the name can cause
collisions when both fail. Upload it as
`${{ matrix.cc }}-${{ matrix.sdk}}-config.log'
instead so that it is unique.
aws-nslick
force-pushed
the
gh-actions-faster
branch
2 times, most recently
from
498bc8e
to
609490e
Compare
Install and build with both the default version of the compiler in the repos, as well as the latest available via either the ubuntu toolchain team gcc builds, or the llvm apt repos.
With more elements in the test matrix, fail-fast helps shift left. Rather than seeing 4-5 different failures, just stop immediately with the error message responsible.
on eg: force pushes while a job is still running, make the start of the new job cancel the old job. head_ref is undefined on non-pull_request runs per their docs.
+ ignore unit tests + disable unused parameter warnings.
Move codechecker to its own job, gated but the success of the distbuilds.
lttng defaults to on, so nothing is required other than installing it conditionally. Add a build for it.
aws-nslick
force-pushed
the
gh-actions-faster
branch
from
609490e
to
504b37f
Compare
bwbarrett
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Notable things:
Issue #, if available:
Non-issues, but related commits around recent bugs that this would have helped catch:
(This commit adds an lttng build variant)