Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed cfncluster_version to parallelcluster_version #234

Merged
merged 1 commit into from
Dec 14, 2018

Conversation

sean-smith
Copy link
Contributor

@sean-smith sean-smith commented Dec 13, 2018

$ grep -r "cfncluster_version" .
[nothing]
$ grep -r "cfncluster_cookbook_version" .
[nothing]

Signed-off-by: Sean Smith seaam@amazon.com

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

fnubalaj
fnubalaj previously approved these changes Dec 14, 2018
@@ -1,6 +1,6 @@
{
"variables" : {
"cfncluster_version" : "",
"parallelcluster_version" : "",
"cfncluster_cookbook_version" : "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we keeping cfncluster here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@@ -1,6 +1,6 @@
{
"variables" : {
"cfncluster_version" : "",
"parallelcluster_version" : "",
"cfncluster_cookbook_version" : "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we keeping cfncluster here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@@ -1,6 +1,6 @@
{
"variables" : {
"cfncluster_version" : "",
"parallelcluster_version" : "",
"cfncluster_cookbook_version" : "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we keeping cfncluster here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@@ -1,6 +1,6 @@
{
"variables" : {
"cfncluster_version" : "",
"parallelcluster_version" : "",
"cfncluster_cookbook_version" : "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we keeping cfncluster here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@@ -1,6 +1,6 @@
{
"variables" : {
"cfncluster_version" : "",
"parallelcluster_version" : "",
"cfncluster_cookbook_version" : "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we keeping cfncluster here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@@ -1,5 +1,5 @@
{
"cfncluster_version": "2.0.2",
"parallelcluster_version": "2.0.2",
"cfncluster_cookbook_version": "2.0.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we keeping cfncluster here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Signed-off-by: Sean Smith <seaam@amazon.com>
@sean-smith sean-smith merged commit 7dd5f94 into aws:develop Dec 14, 2018
@sean-smith sean-smith deleted the parallelcluster-version branch January 15, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants