Skip to content

Commit

Permalink
feat(monorepo): force usage of pnpm 8 (#782)
Browse files Browse the repository at this point in the history
fix #772
  • Loading branch information
agdimech committed May 8, 2024
1 parent 81e6d78 commit c9be133
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 9 deletions.
2 changes: 1 addition & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ RUN set -ex \
# ===== PDK dependencies =====

# Package managers
RUN npm install -g @aws/pdk aws-cdk bun pnpm projen yarn
RUN npm install -g @aws/pdk aws-cdk bun pnpm@8 projen yarn

# Poetry setup
RUN curl -sSL https://install.python-poetry.org | python
Expand Down
1 change: 1 addition & 0 deletions docker/dockerbuild.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#!/bin/bash

aws ecr-public get-login-password --region us-east-1 | docker login --username AWS --password-stdin public.ecr.aws/p9i6h6j0
docker buildx build . -t aws-pdk --platform linux/amd64
docker tag aws-pdk:latest public.ecr.aws/p9i6h6j0/aws-pdk:latest
docker push public.ecr.aws/p9i6h6j0/aws-pdk:latest
2 changes: 1 addition & 1 deletion package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/monorepo/src/components/nx-configurator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ export class NxConfigurator extends Component implements INxProjectCore {
private: true,
engines: {
node: ">=16",
pnpm: ">=8",
pnpm: ">=8 <9",
},
scripts: Object.fromEntries(
this.project.tasks.all
Expand Down
2 changes: 1 addition & 1 deletion packages/monorepo/src/projects/typescript/monorepo-ts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ export class MonorepoTsProject
case NodePackageManager.PNPM: {
// https://pnpm.io/package_json
// https://github.com/pnpm/pnpm/releases/tag/v8.0.0
this.package.addEngine("pnpm", ">=8");
this.package.addEngine("pnpm", ">=8 <9");
break;
}
case NodePackageManager.YARN_CLASSIC:
Expand Down
6 changes: 3 additions & 3 deletions packages/monorepo/test/__snapshots__/monorepo.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit c9be133

Please sign in to comment.