You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When upgrading to the latest version of PDK unexpected license files have appeared.
Expected Behavior
No license to be generated when a subproject sets licensed: false.
Current Behavior
Many LICENSE files have been generated even though their projects set licensed: false.
Reproduction Steps
import { javascript } from "projen";
import { monorepo } from "@aws/pdk";
import { NodeProject } from "projen/lib/javascript";
const project = new monorepo.MonorepoTsProject({
devDeps: ["@aws/pdk"],
name: "example",
packageManager: javascript.NodePackageManager.PNPM,
projenrcTs: true,
});
new NodeProject({
parent: project,
name: "nolicense",
outdir: "packages/nolicense",
defaultReleaseBranch: "main",
licensed: false,
packageManager: javascript.NodePackageManager.PNPM,
});
project.synth();
produces packages/nolicense/LICENSE as an Apache 2.0 license even though it specifically set licensed to false.
Possible Solution
Sadly I don't see a clear path to easily support this because the licensed property is not made available anywhere. Maybe just a way to opt-out of the _addLicenses feature entirely?
Additional Information/Context
No response
PDK version used
0.23.19
What languages are you seeing this issue on?
Typescript
Environment details (OS name and version, etc.)
Amazon AL2
The text was updated successfully, but these errors were encountered:
Describe the bug
When upgrading to the latest version of PDK unexpected license files have appeared.
Expected Behavior
No license to be generated when a subproject sets
licensed: false
.Current Behavior
Many LICENSE files have been generated even though their projects set
licensed: false
.Reproduction Steps
produces packages/nolicense/LICENSE as an Apache 2.0 license even though it specifically set licensed to false.
Possible Solution
Sadly I don't see a clear path to easily support this because the
licensed
property is not made available anywhere. Maybe just a way to opt-out of the_addLicenses
feature entirely?Additional Information/Context
No response
PDK version used
0.23.19
What languages are you seeing this issue on?
Typescript
Environment details (OS name and version, etc.)
Amazon AL2
The text was updated successfully, but these errors were encountered: