Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Yum on Node Build Images #16

Closed
metaskills opened this issue Jun 25, 2021 · 4 comments
Closed

Missing Yum on Node Build Images #16

metaskills opened this issue Jun 25, 2021 · 4 comments
Labels
dependencies node

Comments

@metaskills
Copy link

I have noticed that both of these images are missing yum where all the other SAM build images have it.

  • amazon/aws-sam-cli-build-image-nodejs12.x
  • amazon/aws-sam-cli-build-image-nodejs14.x

Yum is also installed on each Lambda runtime public.ecr.aws/lambda/... (including the node versions above) images and our tooling requires that they also be on the build image. Thinking it is a big oversight that somehow these are missing?
@metaskills
Copy link
Author

Learned about these images (https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/serverless-image-repositories.html) from @julianwood on twitter and they indeed are missing yum too.

@hoffa hoffa transferred this issue from aws/aws-sam-cli Jun 25, 2021
This was referenced Jun 25, 2021
Merged
Closed
@hoffa hoffa added the node label Jun 25, 2021
@hoffa
Copy link

hoffa commented Jun 25, 2021

Thanks for reporting this! The ECR images now include yum.

@metaskills
Copy link
Author

Thanks! I can confirm they are now in these images:

  • public.ecr.aws/sam/build-nodejs12.x
  • public.ecr.aws/sam/build-nodejs14.x

Not seeing them in the older versions in the desc above but that is fine, I think we should be moving to these newer ones anyway. Cheers!

@hoffa
Copy link

hoffa commented Jul 6, 2021

Thanks! The DockerHub images have also been updated.

mndeveci added a commit to mndeveci/aws-sam-build-images that referenced this issue Apr 17, 2023
@anton-stepanof @mndeveci
feat: add java17 support (aws#16)
5763de7 
* Add java 17 support

* Add java 17 docker file

* Add java 17 tests

* Fix review comments. Update gradle version

---------

Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
mndeveci added a commit that referenced this issue Apr 20, 2023
@mndeveci @anton-stepanof
feat: add java17 support (#16) (#84)
7dd59e1 
* feat: add java17 support (#16)

* Add java 17 support

* Add java 17 docker file

* Add java 17 tests

* Fix review comments. Update gradle version

---------

Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>

* update mvn version which is compatible with java17

* skip java17 arm64 tests for now

---------

Co-authored-by: Anton Stepanov <110172761+anton-stepanof@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies node
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@metaskills @hoffa