Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Bump aws-sam-translator #1043

Merged
merged 1 commit into from Mar 7, 2019

Conversation

jfuss
Copy link
Contributor

@jfuss jfuss commented Mar 7, 2019

Issue #, if available:

Description of changes:
Bump version of aws-sam-translator.

This PR also removes a monkey patch we created to suppress some root level logging the aws-sam-translator was doing. With the release of 1.10.0, there is no longer a loggingmodule in the samtranslator.parser.parser module. When running make pr, pylint was complaining about this as well (see below)

************* Module samcli.commands.validate.lib.sam_template_validator
E: 81,39: Module 'samtranslator.parser.parser' has no 'logging' member (no-member)

Checklist:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@sriram-mv sriram-mv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants