Managed S3 Bucket via optional bootstrap command #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing: Integration with config files. We may also want to move some of the echo commands to debug logging.
sanathkr
reviewed
Nov 13, 2019
sanathkr
suggested changes
Nov 14, 2019
sanathkr
changed the title
sanathkr
changed the title
sriram-mv
requested changes
Nov 15, 2019
samcli/lib/bootstrap/bootstrap.py
Outdated
| LOG = logging.getLogger(__name__) | ||
| SAM_CLI_STACK_NAME = "aws-sam-cli-managed-stack" | ||
|
|
||
| MANAGED_STACK_DEFINITION = """ |
There was a problem hiding this comment.
- this lives in a separate file?
- can we add the version number of sam cli with which this stack was created?
Any other cheap metadata we can add today?
There was a problem hiding this comment.
- separate file: Yeah, the template is small. it's cheap to have it here. we will move out later
- metadata: Good idea!
sriram-mv
approved these changes
Nov 15, 2019
sriram-mv
pushed a commit
that referenced
this pull request
Nov 20, 2019
* WIP: Managed S3 Stack * Managed S3 Bucket Command With Tests Missing: Integration with config files. We may also want to move some of the echo commands to debug logging. * Setup Design Doc * Setup Design Document * Rename to and remove CLI interface * Fix lint errors * Adding metadata to stack * fixing black formatting
sriram-mv
pushed a commit
that referenced
this pull request
Nov 23, 2019
* WIP: Managed S3 Stack * Managed S3 Bucket Command With Tests Missing: Integration with config files. We may also want to move some of the echo commands to debug logging. * Setup Design Doc * Setup Design Document * Rename to and remove CLI interface * Fix lint errors * Adding metadata to stack * fixing black formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides logic for creating or reading from a managed CloudFormation stack which contains an S3 bucket.
This is a WIP in that it should be integrated with ongoing config work, it is not ready to merge until it is tied in to seeding such a config file with the retrieved bucket name. Please do feel free to use a different branch as the base.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.