Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes API Event from Inline Test #1671

Merged
merged 2 commits into from Dec 17, 2019
Merged

Removes API Event from Inline Test #1671

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43371ef
Removes API Event from Inline Test
awood45 Dec 16, 2019
b703315
Merge branch 'develop' into remove-api-gw-from-deploy-test
jfuss Dec 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 0 additions & 6 deletions tests/integration/testdata/package/aws-serverless-inline.yaml
View file
Open in desktop
Expand Up @@ -12,9 +12,3 @@ Resources:
return {'body': 'Hello World 2!', 'statusCode': 200}
Handler: index.handler
Runtime: python3.7
Events:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without API gateway how are we validating if Lambda is working? Are we invoking it directly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That brings up a good point, what we check for here is that we can deploy a particular template and check for return codes, but we dont attempt to check if the components that are deployed actually work. This may be a new set of end to end tests we may need to adopt.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while it could be valuable to test the function, it’s not the scope of these tests. We want to make sure the deploy can happen successfully. I can see value in verifying configuration of what was deployed, but that kind of a grey area to me and not really testing lambda either.

Api:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also why are we removing it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not need, and would require more permissions for our integration tests to work.

Type: Api
Properties:
Path: /
Method: get