Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ux: improve deploy outputs text #1788

Merged
merged 2 commits into from
Feb 11, 2020
Merged

Conversation

sriram-mv
Copy link
Contributor

@sriram-mv sriram-mv commented Feb 11, 2020

  • easier to grok the outputs from the deployed stack
  • (Key, Description, Value) are new line separated to provide a clean
    interface.
  • Change stack outputs colors to green as they indicate a successfully
    deployed stack.

Preview

SAM CLI Output

Issue #, if available:

#1659

Why is this change necessary?

  • Hard to copy/paste outputs

How does it address the issue?

  • All output value start from a minimal offset so that they have enough width to showcase without breaks.

What side effects does this change have?

  • A potentially super long output value could still flow over to the next line.

Checklist:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@sanathkr sanathkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the kwargs named more explicit to showcase the coupling?

* easier to grok the outputs from the deployed stack
* (Key, Description, Value) are new line separated to provide a clean
interface.
* Change stack outputs colors to green as they indicate a successfully
deployed stack.
@sriram-mv
Copy link
Contributor Author

@sanathkr : Great catch! Adding a docstring as well to showcase what it means.

@sriram-mv sriram-mv merged commit fa19f22 into aws:develop Feb 11, 2020
@mstempniewicz-stx
Copy link

Hey guys, any update on this? I guess a lot of people would appreciate this feature.

@tgdavies
Copy link

Did this ever get released? I still get values split between lines in SAM CLI, version 1.35.0:

Key WebsiteURL
Description URL for website hosted on S3
Value http://test-stack-frontendbucket-xxxxxxxxxxxxx.s3-website-ap-
southeast-2.amazonaws.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants