feat: adding separate bucket based on python version for integration tests. #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfuss
requested changes
Feb 27, 2020
| @@ -14,7 +14,22 @@ class PackageIntegBase(TestCase): | |||
| @classmethod | |||
| def setUpClass(cls): | |||
| cls.region_name = os.environ.get("AWS_DEFAULT_REGION") | |||
There was a problem hiding this comment.
This should be below doc strings.
There was a problem hiding this comment.
Actually doc string is only for the line where we are reading AWS_S3 and not for the whole method. That is why I didn't move this below docstring. Thoughts?
|
|
||
| For Python36: | ||
| AWS_S3=AWS_S3_36 | ||
| AWS_S3_36=aws-sam-cli-canary-region-awssamclitestbucket-forpython36 |
There was a problem hiding this comment.
Do no document bucket names.
There was a problem hiding this comment.
This is not a real bucket name. Something I made up based on how real name looks like.
|
|
||
| For backwards compatibility we are falling back to reading AWS_S3 so that current tests keep working. | ||
| """ | ||
| cls.pre_created_bucket = os.environ.get(os.environ.get("AWS_S3", False), os.environ.get("AWS_S3")) |
There was a problem hiding this comment.
Break this line up, I am having a hard time following the nested calls here.
| @@ -16,7 +16,8 @@ class PublishAppIntegBase(TestCase): | |||
| @classmethod | |||
| def setUpClass(cls): | |||
| cls.region_name = os.environ.get("AWS_DEFAULT_REGION") | |||
| cls.pre_created_bucket = os.environ.get("AWS_S3", False) | |||
| """Please read comments in package_integ_base.py for more details around this.""" | |||
| cls.pre_created_bucket = os.environ.get(os.environ.get("AWS_S3", False), os.environ.get("AWS_S3")) | |||
| @@ -17,7 +17,8 @@ class PackageRegressionBase(TestCase): | |||
| @classmethod | |||
| def setUpClass(cls): | |||
| cls.region_name = os.environ.get("AWS_DEFAULT_REGION") | |||
| cls.pre_created_bucket = os.environ.get("AWS_S3", False) | |||
| """Please read comments in package_integ_base.py for more details around this.""" | |||
| cls.pre_created_bucket = os.environ.get(os.environ.get("AWS_S3", False), os.environ.get("AWS_S3")) | |||
jfuss
reviewed
Feb 27, 2020
| """ | ||
| cls.pre_created_bucket = os.environ.get( | ||
| os.environ.get("AWS_S3", False), # Reading env var key for specific bucket. | ||
| os.environ.get("AWS_S3"), # Fallback to old logic if separate env key not present. |
There was a problem hiding this comment.
This is not the same fallback. The previous fallback had a value of False.
jfuss
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Why is this change necessary?
Our integration tests use S3 bucket to run several tests. Given that S3 objects are eventually consistent and we are using same bucket for lot of integration tests, we want to have multiple buckets to reduce transient failures. This change will allow referring correct bucket based on the python version for which test is running.
How does it address the issue?
This spreads total number of objects across several buckets and improving sync time to reduce time it takes by S3 to be consistent.
What side effects does this change have?
NA
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.