fix: bug around using temporary credentials in event bridge integration test. #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfuss
reviewed
Feb 27, 2020
| def _create_cred_file(self, profile, access_key, secret_key): | ||
| cred_file_content = "[default]\naws_access_key_id = {1}\naws_secret_access_key = {2}\n" | ||
| def _create_cred_file(self, profile, access_key, secret_key, session_token=None): | ||
| cred_file_content = self._create_cred_profile("default", access_key, secret_key, session_token) |
There was a problem hiding this comment.
Doesn't this need to be [default]?
There was a problem hiding this comment.
O... this is moved down to the helper method below.
There was a problem hiding this comment.
That is taken care of in the method line 133. It is [{profile_name}]
jfuss
reviewed
Feb 27, 2020
| aws_access_key_id = {access_key} | ||
| aws_secret_access_key = {secret_key} | ||
| """ | ||
| cred_profile_content += f"aws_session_token={session_token}\n" |
There was a problem hiding this comment.
Why not have this in the cred_profile_content above?
There was a problem hiding this comment.
Ohh that is a miss, there is supposed to be an if in there to add this only if session_token is passed. Lost somewhere in merging. I'll fix it.
jfuss
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Why is this change necessary?
Event bridge integration tests do no respect session token to run secure tests. This code change fixes that.
How does it address the issue?
Using session token if present.
What side effects does this change have?
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.