New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(package): NamedTemporaryFile Being Opened Twice #2567
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
ceeba56
Bumped aws-sam-translator to 1.27.0
CoshUS bb11702
Bumped SAM CLI Version to 1.3.0
CoshUS e627c6d
Updated Reproducible Requirements
385041e
Merge branch 'develop' of https://github.com/aws/aws-sam-cli into dev…
CoshUS d3da38f
Merge remote-tracking branch 'upstream/develop' into develop
CoshUS 24923f8
Merge remote-tracking branch 'upstream/develop' into develop
CoshUS 218e731
Merge remote-tracking branch 'upstream/develop' into develop
CoshUS af18a89
Merge remote-tracking branch 'upstream/develop' into develop
CoshUS 105538a
Merge remote-tracking branch 'upstream/develop' into develop
CoshUS 320c497
Merge remote-tracking branch 'upstream/develop' into develop
CoshUS 862be0f
Merge remote-tracking branch 'upstream/develop' into develop
CoshUS 31bed23
Merge remote-tracking branch 'upstream/develop' into develop
CoshUS ba1c1b4
Merge remote-tracking branch 'upstream/develop' into develop
CoshUS 5a14c86
Merge remote-tracking branch 'upstream/develop' into develop
CoshUS 847fc5b
Merge remote-tracking branch 'upstream/develop' into develop
CoshUS 89ec2fb
Merge remote-tracking branch 'upstream/develop' into develop
CoshUS c781bc3
Added Close to Packaged File
CoshUS a4e3b1c
Removed Debug Prints
CoshUS 85f262a
Removed Debug Vars
CoshUS 3af5752
Removed Another Debug Print
CoshUS 2a0bd53
Formatting
CoshUS ea9d847
Merge branch 'develop' into fix/package-named-temp-file
CoshUS bf660d0
Merge branch 'develop' into fix/package-named-temp-file
CoshUS File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use
TemporaryFile()
forpackage_file
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TemporaryFile does not guarantee the file is visible in the file system on Unix. We need to read the file later using packaged_file.name in order to validate the output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a visible name for
package_file
in the file system, which is used foroutput_template_file
in the command.TemporaryFile()
does not guarantee a visible name in the file system.We don't need the file to actually exist though. Since the command will create the file again