Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update build graph to include handler for esbuild comparison #3636

Merged
merged 4 commits into from
Feb 11, 2022

Conversation

mildaniel
Copy link
Contributor

Update the build definition comparison to handle esbuild needing a separate build for each handler.

Checklist

  • Add input/output type hints to new functions/methods
  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added area/build sam build command pr/internal labels Feb 10, 2022
@mildaniel mildaniel merged commit cb7adc3 into aws:develop Feb 11, 2022
@mildaniel mildaniel deleted the build-def-comparison branch February 11, 2022 16:10
mndeveci pushed a commit to mndeveci/aws-sam-cli that referenced this pull request Apr 5, 2022
…ws#3636)

* Update build graph to include handler

* Add comment

* Remove deepcopy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build sam build command pr/internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants