Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Pull Request Template #3641

Merged
merged 5 commits into from Mar 3, 2022
Merged

feat: Update Pull Request Template #3641

merged 5 commits into from Mar 3, 2022

Conversation

CoshUS
Copy link
Contributor

@CoshUS CoshUS commented Feb 11, 2022

Which issue(s) does this change fix?

N/A

Why is this change necessary?

To highlight mandatory checklist.

How does it address the issue?

N/A

What side effects does this change have?

N/A

Checklist

  • Add input/output type hints to new functions/methods
  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@CoshUS CoshUS requested a review from qingchm February 14, 2022 17:06
@jfuss jfuss added the stage/pr-approved PR is approved but shouldn't be merged for now label Mar 3, 2022
@jfuss jfuss self-assigned this Mar 3, 2022
@CoshUS CoshUS merged commit 2d61c1c into develop Mar 3, 2022
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Apr 5, 2022
* Update PULL_REQUEST_TEMPLATE.md

* Updated Functional Tests to be Conditional

Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
Co-authored-by: Jacob Fuss <32497805+jfuss@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/internal stage/pr-approved PR is approved but shouldn't be merged for now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants