Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update Pull Request Template #3641

Merged
merged 5 commits into from Mar 3, 2022
Merged

feat: Update Pull Request Template #3641

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
286b40f
Update PULL_REQUEST_TEMPLATE.md
CoshUS Feb 11, 2022
574a32a
Updated Functional Tests to be Conditional
CoshUS Feb 14, 2022
d3191ed
Merge branch 'develop' into pr-template-update
CoshUS Feb 14, 2022
f4736e7
Merge branch 'develop' into pr-template-update
mndeveci Feb 16, 2022
d4aaf48
Merge branch 'develop' into pr-template-update
jfuss Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
@@ -1,19 +1,24 @@
#### Which issue(s) does this change fix?
<!-- Use the format #<issue-number>, e.g. #42 -->


#### Why is this change necessary?


#### How does it address the issue?


#### What side effects does this change have?

#### Checklist

#### Mandatory Checklist
**PRs will only be reviewed after checklist is complete**

- [ ] Add input/output [type hints](https://docs.python.org/3/library/typing.html) to new functions/methods
- [ ] Write design document ([Do I need to write a design document?](https://github.com/aws/aws-sam-cli/blob/develop/DEVELOPMENT_GUIDE.md#design-document))
- [ ] Write unit tests
- [ ] Write/update functional tests
- [ ] Write design document if needed ([Do I need to write a design document?](https://github.com/aws/aws-sam-cli/blob/develop/DEVELOPMENT_GUIDE.md#design-document))
- [ ] Write/update unit tests
- [ ] Write/update integration tests
- [ ] Write/update functional tests if needed
- [ ] `make pr` passes
- [ ] `make update-reproducible-reqs` if dependencies were changed
- [ ] Write documentation
Expand Down