Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(release): add homebrew-core bump job #4614

Closed
wants to merge 1 commit into from
Closed

ci(release): add homebrew-core bump job #4614

wants to merge 1 commit into from

Conversation

chenrui333
Copy link

@chenrui333 chenrui333 commented Jan 24, 2023 •
edited
Loading

Which issue(s) does this change fix?

fixes #4607

Why is this change necessary?

Automate the homebrew-core formula version bump

How does it address the issue?

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

relates to Homebrew/homebrew-core#120653

cc @mndeveci @torresxb1

@chenrui333 chenrui333 requested a review from a team as a code owner January 24, 2023 20:21
@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Jan 24, 2023
@chenrui333 chenrui333 mentioned this pull request Jan 24, 2023
Closed
6 tasks
@chenrui333
Copy link
Author

Notes

Two TODOs with this PR:

torresxb1
torresxb1 reviewed Jan 25, 2023
View reviewed changes
Copy link
Contributor

@torresxb1 torresxb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chenrui333 , thanks so much for contributing! Left a question and a note that I need to discuss with the team because I think we might need a security review

.github/workflows/brew.yml Outdated Show resolved Hide resolved
.github/workflows/brew.yml Show resolved Hide resolved
@torresxb1 torresxb1 added blocked/pending-security-review The PR cannot be merged or reviewed due to pending security review. and removed stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Jan 25, 2023
@chenrui333
Copy link
Author

Thanks for the review :)

@chenrui333
ci(release): add homebrew-core bump job
7e19f46 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
Copy link
Author

Once this gets accepted, we can do something like this to migrate the tap to core.

carlocab
carlocab reviewed Mar 2, 2023
View reviewed changes
.github/workflows/brew.yml
name: Bump homebrew-core formula
runs-on: ubuntu-latest
steps:
- uses: mislav/bump-homebrew-formula-action@v2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use https://github.com/dawidd6/action-homebrew-bump-formula since aws-sam-cli has Python resources that need updating, which mislav/bump-homebrew-formula-action does not update.

@carlocab carlocab mentioned this pull request Mar 2, 2023
Merged
6 tasks
carlocab added a commit to carlocab/homebrew-core that referenced this pull request Mar 3, 2023
@carlocab
aws-sam-cli: retain non-native binaries
f092c3b 
These binaries are for use inside containers which might be running a
different architecture.

Also, add this to the autobump list since upstream has issues when there
are delayed updates to users.

Fixes Homebrew/discussions#4290
Fixes aws/aws-sam-cli#4771
Fixes aws/aws-sam-cli#4684
Fixes aws/aws-sam-cli#4607
Closes aws/aws-sam-cli#4614

Closes Homebrew#124616.

Signed-off-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
carlocab added a commit to Homebrew/homebrew-core that referenced this pull request Mar 4, 2023
@carlocab
aws-sam-cli: retain non-native binaries
fbe8769 
These binaries are for use inside containers which might be running a
different architecture.

Also, add this to the autobump list since upstream has issues when there
are delayed updates to users.

Fixes Homebrew/discussions#4290
Fixes aws/aws-sam-cli#4771
Fixes aws/aws-sam-cli#4684
Fixes aws/aws-sam-cli#4607
Closes aws/aws-sam-cli#4614

Closes #124616.

Signed-off-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
@mndeveci
Copy link
Contributor

mndeveci commented Mar 8, 2023

Thanks for your efforts. As a team, we decided not to move forward with this PR and let the community to handle it. We strongly recommend our customers to use our tap when installing/updating AWS SAM CLI (brew install aws/tap/aws-sam-cli) since we can control the whole experience and timely releases. Appreciate your understanding.

@mndeveci mndeveci closed this Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab left review comments

@torresxb1 torresxb1 torresxb1 left review comments

@hnnasit hnnasit Awaiting requested review from hnnasit hnnasit is a code owner automatically assigned from aws/serverless-application-experience-sbt

Assignees
No one assigned
Labels
blocked/pending-security-review The PR cannot be merged or reviewed due to pending security review. pr/external
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Announcement] Installing/Updating AWS SAM CLI through Homebrew
4 participants
@chenrui333 @mndeveci @carlocab @torresxb1