-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-sam-cli: retain non-native binaries #124616
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrewTestBot
added
the
automerge-skip
`brew pr-automerge` will skip this pull request
label
Mar 2, 2023
SMillerDev
previously approved these changes
Mar 2, 2023
dawidd6
previously approved these changes
Mar 2, 2023
MikeMcQuaid
previously approved these changes
Mar 2, 2023
Oops:
Can someone with push access do |
BrewTestBot
dismissed stale reviews from SMillerDev, MikeMcQuaid, and dawidd6
March 2, 2023 11:09
bottle publish failed
These binaries are for use inside containers which might be running a different architecture. Also, add this to the autobump list since upstream has issues when there are delayed updates to users. Fixes Homebrew/discussions#4290 Fixes aws/aws-sam-cli#4771 Fixes aws/aws-sam-cli#4684 Fixes aws/aws-sam-cli#4607 Closes aws/aws-sam-cli#4614 Closes Homebrew#124616. Signed-off-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
carlocab
added
the
CI-syntax-only
Change only affects brew syntax, not the install. Only run syntax CI.
label
Mar 3, 2023
Pushed the bottle commit here so this can be merged in the GitHub UI. |
chenrui333
approved these changes
Mar 3, 2023
fxcoudert
approved these changes
Mar 4, 2023
carlocab
added a commit
that referenced
this pull request
Mar 4, 2023
These binaries are for use inside containers which might be running a different architecture. Also, add this to the autobump list since upstream has issues when there are delayed updates to users. Fixes Homebrew/discussions#4290 Fixes aws/aws-sam-cli#4771 Fixes aws/aws-sam-cli#4684 Fixes aws/aws-sam-cli#4607 Closes aws/aws-sam-cli#4614 Closes #124616. Signed-off-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
automerge-skip
`brew pr-automerge` will skip this pull request
CI-syntax-only
Change only affects brew syntax, not the install. Only run syntax CI.
outdated
PR was locked due to age
ready to merge
PR can be merged once CI is green
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?These binaries are for use inside containers which might be running a
different architecture.
Also, add this to the autobump list since upstream has issues when there
are delayed updates to users.
Fixes Homebrew/discussions#4290
Fixes aws/aws-sam-cli#4771
Fixes aws/aws-sam-cli#4684
Fixes aws/aws-sam-cli#4607
Closes aws/aws-sam-cli#4614