Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-sam-cli: retain non-native binaries #124616

Merged
merged 2 commits into from
Mar 4, 2023
Merged

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Mar 2, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

These binaries are for use inside containers which might be running a
different architecture.

Also, add this to the autobump list since upstream has issues when there
are delayed updates to users.

Fixes Homebrew/discussions#4290
Fixes aws/aws-sam-cli#4771
Fixes aws/aws-sam-cli#4684
Fixes aws/aws-sam-cli#4607
Closes aws/aws-sam-cli#4614

@carlocab carlocab requested review from MikeMcQuaid and a team as code owners March 2, 2023 07:45
@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 2, 2023
SMillerDev
SMillerDev previously approved these changes Mar 2, 2023
dawidd6
dawidd6 previously approved these changes Mar 2, 2023
MikeMcQuaid
MikeMcQuaid previously approved these changes Mar 2, 2023
@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@carlocab
Copy link
Member Author

carlocab commented Mar 2, 2023

Oops:

/usr/bin/git push origin master
To https://github.com/Homebrew/homebrew-core
 ! [remote rejected]         master -> master (refusing to allow a Personal Access Token to create or update workflow `.github/workflows/autobump.yml` without `workflow` scope)
error: failed to push some refs to 'https://github.com/Homebrew/homebrew-core'

Can someone with push access do brew pr-pull --warn-on-upload-failure 124616 here? CC @Homebrew/tsc

@BrewTestBot
Copy link
Member

⚠️ @carlocab bottle publish failed.

@BrewTestBot BrewTestBot dismissed stale reviews from SMillerDev, MikeMcQuaid, and dawidd6 March 2, 2023 11:09

bottle publish failed

These binaries are for use inside containers which might be running a
different architecture.

Also, add this to the autobump list since upstream has issues when there
are delayed updates to users.

Fixes Homebrew/discussions#4290
Fixes aws/aws-sam-cli#4771
Fixes aws/aws-sam-cli#4684
Fixes aws/aws-sam-cli#4607
Closes aws/aws-sam-cli#4614

Closes Homebrew#124616.

Signed-off-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
@carlocab carlocab added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Mar 3, 2023
@carlocab carlocab added the ready to merge PR can be merged once CI is green label Mar 3, 2023
@carlocab carlocab enabled auto-merge (rebase) March 3, 2023 14:07
@carlocab
Copy link
Member Author

carlocab commented Mar 3, 2023

Pushed the bottle commit here so this can be merged in the GitHub UI.

@carlocab carlocab merged commit cdcf34e into Homebrew:master Mar 4, 2023
carlocab added a commit that referenced this pull request Mar 4, 2023
These binaries are for use inside containers which might be running a
different architecture.

Also, add this to the autobump list since upstream has issues when there
are delayed updates to users.

Fixes Homebrew/discussions#4290
Fixes aws/aws-sam-cli#4771
Fixes aws/aws-sam-cli#4684
Fixes aws/aws-sam-cli#4607
Closes aws/aws-sam-cli#4614

Closes #124616.

Signed-off-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
@carlocab carlocab deleted the aws-sam-cli branch March 4, 2023 11:05
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
7 participants