fix: Preserve file permissions when decompressing a zip file #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #389 Zip archive format includes a `external_attr` property on each file that stores file permissions. Most zip programs store permissions as in a format that unix's `chmod` command will accept. I cross-verified this approach with a couple of other libraries: * [Setuptools](https://github.com/pypa/setuptools/blob/89ef5bb7e4812193d6f593d531bad36191517981/setuptools/archive_util.py#L122-L124) * [Golang source](https://github.com/golang/go/blob/161874da2ab6d5372043a1f3938a81a19d1165ad/src/archive/zip/struct.go#L273) Unit tests create a zip archive with different permissions to verify that it does in fact unzip with permissons. This includes integration tests that invoke a function with zip of code for Java & Golang. We can run these automated tests on various platforms (Mac, Linux, Windows) to ensure unzipping works consistently.
This was referenced Jun 6, 2018
jfuss
reviewed
Jun 8, 2018
| from subprocess import Popen, PIPE | ||
| from nose_parameterized import parameterized, param | ||
|
|
||
| from ..invoke_integ_base import InvokeIntegBase |
There was a problem hiding this comment.
Should only be using . not ... Can you change this to full path?
| cls.test_data_path = os.path.join(integration_dir, "testdata") | ||
| cls.template_path = os.path.join(cls.test_data_path, "invoke", "template.yml") | ||
| cls.event_path = os.path.join(cls.test_data_path, "invoke", "event.json") | ||
| cls.env_var_path = os.path.join(cls.test_data_path, "invoke", "vars.json") |
There was a problem hiding this comment.
I am going to skip this one for now. Path definitely simplifies this expression but let's get to it in a separate pass of converting os.path to Path
jfuss
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #389
Zip archive format includes a
external_attrproperty on each filethat stores file permissions. Most zip programs store permissions as
in a format that unix's
chmodcommand will accept. I cross-verifiedthis approach with a couple of other libraries:
Unit tests create a zip archive with different permissions to verify that it
does in fact unzip with permissons. This includes integration tests that
invoke a function with zip of code for Java & Golang. We can run these
automated tests on various platforms (Mac, Linux, Windows) to ensure unzipping
works consistently.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.