fix: Proper setting of permissions for the tempdir on posix systems. Updated integ-test. #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fl3x1324 Can we just check in the jar instead of adding all the maven stuff? |
|
If you consider it a better move. I'm ok with it either way. Shall I create a new PR? |
|
@fl3x1324 Didn't realized you commented here. I pushed a commit to remove those pieces and it is building now. Previous to your commit, the integ tests were failing for me on mac as well (for java8). |
sanathkr
suggested changes
Jun 18, 2018
| @@ -188,6 +188,9 @@ def _unzip_file(filepath): | |||
|
|
|||
| temp_dir = tempfile.mkdtemp() | |||
|
|
|||
| if os.name == 'posix': | |||
sanathkr
approved these changes
Jun 18, 2018
|
@fl3x1324 Thanks a ton for triaging the issue and submitting a PR! This was tricky one because it worked on some machines and didn't on others. And hey, congrats on your first PR 🎉 |
|
Hooray! Thanks guys! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#462
Description of changes:Proper setting of permissions for the tempdir on posix systems. Updated integ-test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.