Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: travis CI support for Python 3.7 #679

Merged
merged 3 commits into from
Oct 9, 2018

Conversation

sriram-mv
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfuss
Copy link
Contributor

jfuss commented Sep 25, 2018

@thesriram Do we need to be updating tox.ini or DEVELOPMENT_GUIDE.rst with Py37 things.

If we are supporting 3.7, we should add the classifier in the classifiers dict of setup.py.

@sanathkr
Copy link
Contributor

@jfuss Yes I think we should. They are small enough that we can bundle it in this PR

@sriram-mv
Copy link
Contributor Author

we could, I had to do some wrangling with symlinks to get tox -e py36 working after adding py37 to tox.ini, but that could be because of brew's python getting updated to 3.7.0 by default.

* Referencing travis-ci/travis-ci#9815
* listed as a current workaround until travis CI comes up with official support for 3.7
Copy link
Contributor

@jfuss jfuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOOT!!! Py3.7 Support!

Random comment:
If we want to always support the new versions, we should figure out a way to automate this away.

@jfuss jfuss merged commit e074fb3 into aws:develop Oct 9, 2018
@sriram-mv sriram-mv mentioned this pull request Oct 19, 2018
heitorlessa added a commit to heitorlessa/aws-sam-cli that referenced this pull request Oct 30, 2018
* develop:
  chore: Version bump aws-sam-translator to 1.8.0 (aws#732)
  docs: add instructions for using local version of SAM Transformer (aws#688)
  docs: Update Docker command to docker (aws#725)
  fix: Iterate over query param list
  chore: Enable Travis to run integ tests
  chore(0.6.1): SAM CLI Version bump (aws#717)
  fix(init/readme): Correct permissions for AWS CLI under requirements (aws#713)
  add pytest-mock for testing (aws#703)
  fix: allow for stdout and stderr streams to be unbufferred directly. (aws#708)
  docs: Add installation instructions for linux (Centos) (aws#670)
  fix: Updated isBase64Encoded value to bool (aws#699)
  fix: correct launch.json for nodejs debugging through VSCode (aws#704)
  docs(usage): Update how to debug Python functions using VS Code (aws#694)
  docs(Cloud9): Reset bash cache on Cloud9 (aws#693)
  docs: Updated virtualenv alias name for 3.7 in guide. (aws#706)
  chore: update aws-sam-translator to 1.7.0 (aws#682)
  feat: travis CI support for Python 3.7 (aws#679)
  docs: Update generate-sample-event-payloads link (aws#702)
  Fix: Raise error for invalid environment variables file (aws#675)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants