Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve tag parsing performance for list input #7049

Merged
merged 1 commit into from
May 10, 2024

Conversation

hawflau
Copy link
Contributor

@hawflau hawflau commented May 10, 2024

Which issue(s) does this change fix?

#6657

Why is this change necessary?

When tags are provided as list via samconfig.toml and certain tag values contain space, performance could be poor as tag parsing will have to do regex parsing with a complex regex pattern.

How does it address the issue?

  • For list input (via samconfig.toml), just convert the list to tuple so each tag is handled separately

What side effects does this change have?

No

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hawflau hawflau requested a review from a team as a code owner May 10, 2024 15:11
@hawflau hawflau added this pull request to the merge queue May 10, 2024
Merged via the queue into aws:develop with commit 5b49ef6 May 10, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants