fix: improve tag parsing performance for list input

samcli/cli/types.py

@@ -208,7 +208,7 @@ def convert(self, value, param, ctx):
         if isinstance(value, list):
             if not value:
                 return result
-            value = " ".join(value)
+            value = tuple(value)
         # if value comes in a via configuration file, it will be a string. So we should still convert it.
         value = (value,) if not isinstance(value, tuple) else value
 

tests/unit/cli/test_types.py

@@ -1,5 +1,5 @@
 from unittest import TestCase
-from unittest.mock import MagicMock, Mock, ANY
+from unittest.mock import MagicMock, Mock, ANY, patch
 
 from click import BadParameter
 from parameterized import parameterized
@@ -244,6 +244,28 @@ def test_successful_parsing(self, input, expected):
         result = self.param_type.convert(input, None, None)
         self.assertEqual(result, expected, msg="Failed with Input = " + str(input))
 
+    @parameterized.expand(
+        [
+            (
+                ["stage=int", "company:application=awesome-service", "company:department=engineering"],
+                {"stage": "int", "company:application": "awesome-service", "company:department": "engineering"},
+            ),
+            (
+                ['owner:name="son of anton"', "company:application=awesome-service", "company:department=engineering"],
+                {
+                    "owner:name": "son of anton",
+                    "company:application": "awesome-service",
+                    "company:department": "engineering",
+                },
+            ),
+        ]
+    )
+    @patch("re.findall")
+    def test_no_regex_parsing_if_input_is_list(self, input, expected, regex_mock):
+        result = self.param_type.convert(input, None, None)
+        self.assertEqual(result, expected, msg="Failed with Input = " + str(input))
+        regex_mock.assert_not_called()
+
 
 class TestCfnTagsMultipleValues(TestCase):
     """