Move checking Docker connectivity to ContainerManager #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfuss
approved these changes
Dec 5, 2018
|
@jfuss more to come 😉 |
sriram-mv
reviewed
Dec 5, 2018
| self._skip_pull_image) | ||
|
|
||
| if not self._container_manager.is_docker_reachable: | ||
| raise InvokeContextException("Running AWS SAM projects locally requires Docker. Have you got it installed?") |
There was a problem hiding this comment.
I wonder if we can say Docker > x version, I think that requires some investigation though.
There was a problem hiding this comment.
@thesriram SAM CLI is constrained to some Docker version?
There was a problem hiding this comment.
Not really, just a way to ask people to upgrade to the latest. There have been some instances where users were using a really old version of docker and had to upgrade. example: to get mounting to work as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Eliminated
_check_docker_connectivity()method and introduced new property inContainerManageris_docker_reachable. Also nowContainerManageris created on__enter__by InvokeContext.Updated tests and added new as required. This is the first part of porting enhancing changes from #774 .
I think we could close #774 now, right?
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.