Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 32-bit build of transfer fails #1512

Closed
2 tasks done
dougnorton opened this issue Nov 12, 2020 · 4 comments
Closed
2 tasks done

Windows 32-bit build of transfer fails #1512

dougnorton opened this issue Nov 12, 2020 · 4 comments
Labels
bug This issue is a bug.

Comments

@dougnorton
Copy link

dougnorton commented Nov 12, 2020

Confirm by changing [ ] to [x] below to ensure that it's a bug:

Describe the bug
When compiling "transfer" for 32-bit the build fails.

SDK version number
1.8 - master

Platform/OS/Hardware/Device
Windows 10

To Reproduce (observed behavior)
mkdir build
cd build
cmake ..\aws-sdk-cpp -G "Visual Studio 15 2017" -DCMAKE_BUILD_TYPE=Release -DBUILD_ONLY="s3;glacier;transfer"
msbuild ALL_BUILD.vcxproj /p:Configuration=Release

Expected behavior
I expect it to build without errors. S3 and glacier compile but transfer fails.

Logs/output
C:\test\aws-sdk-cpp\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(772): error C2220: warning treated as error - no 'object' file generated [C:\test\build\aws-cpp-sdk-transfer\aws-cpp-sdk-transfer.vcxproj]
C:\test\aws-sdk-cpp\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(772): warning C4244: 'initializing': conversion from 'const _Ty' to 'size_t', possible loss of data [C:\test\build\aws-cpp-sdk-transfer\aws-cpp-sdk-transfer.vcxproj]
with
[
_Ty=uint64_t
]
C:\test\aws-sdk-cpp\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(777): warning C4244: 'initializing': conversion from 'uint64_t' to 'size_t', possible loss of data [C:\test\build\aws-cpp-sdk-transfer\aws-cpp-sdk-transfer.vcxproj]
C:\test\aws-sdk-cpp\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(927): warning C4244: 'argument': conversion from 'uint64_t' to 'size_t', possible loss of data [C:\test\build\aws-cpp-sdk-transfer\aws-cpp-sdk-transfer.vcxproj]
C:\test\aws-sdk-cpp\aws-cpp-sdk-core\include\aws/core/utils/memory/AWSMemory.h(66): warning C4244: 'argument': conversion from '_Ty' to 'size_t', possible loss of data [C:\test\build\aws-cpp-sdk-transfer\aws-cpp-sdk-transfer.vcxproj]
with
[
_Ty=uint64_t
] (compiling source file C:\test\aws-sdk-cpp\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp)
C:\test\aws-sdk-cpp\aws-cpp-sdk-core\include\aws/core/utils/memory/AWSMemory.h(258): note: see reference to function template instantiation 'T *Aws::New<T,const _Ty&,unsigned __int64>(const char *,const _Ty &,unsigned __int64 &&)' being compiled
with
[
T=Aws::Utils::Stream::PreallocatedStreamBuf,
_Ty=unsigned char *
] (compiling source file C:\test\aws-sdk-cpp\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp)
C:\test\aws-sdk-cpp\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(827): note: see reference to function template instantiation 'std::unique_ptr<Aws::Utils::Stream::PreallocatedStreamBuf,Aws::DeleterAws::Utils::Stream::PreallocatedStreamBuf> Aws::MakeUnique<Aws::Utils::Stream::PreallocatedStreamBuf,const RESOURCE_TYPE&,uint64_t>(const char *,const RESOURCE_TYPE &,uint64_t &&)' being compiled
with
[
RESOURCE_TYPE=unsigned char *
]

To enable logging, set the following system properties:

REMEMBER TO SANITIZE YOUR PERSONAL INFO

options.loggingOptions.logLevel = Aws::Utils::Logging::LogLevel::Trace;
Aws::InitAPI(options)

Additional context

@dougnorton dougnorton added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 12, 2020
@KaibaLopez
Copy link
Contributor

Hi @dougnorton ,
Thanks for bringing this up for us and yea I can reproduce this as well.

@KaibaLopez KaibaLopez removed the needs-triage This issue or PR still needs to be triaged. label Nov 13, 2020
@KaibaLopez
Copy link
Contributor

Hi @dougnorton ,
This bug should be fixed now, please update to the newest version.

@KaibaLopez KaibaLopez added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Dec 10, 2020
@dougnorton
Copy link
Author

Compiles! Great, thanks for addressing this so quickly!

@github-actions github-actions bot removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Dec 11, 2020
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

2 participants