-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aws-cpp-sdk] [zlib] [openssl] [curl] Fix zlib, OpenSSL, curl and AWS SDK for Android #15725
[aws-cpp-sdk] [zlib] [openssl] [curl] Fix zlib, OpenSSL, curl and AWS SDK for Android #15725
Conversation
Done |
|
I'm struggling to fix it but I don't understand why it works in some envs and not in others! |
@ahmedyarub Is my patch correct? |
Yes! I've just tested it. Thank you very much. |
Need test all features. |
When building
|
This is not related at all to my changes. The current VCPKG version has this bug: aws/aws-sdk-cpp#1512 |
…cpkg into fix_aws_sdk_android
…aws_sdk_android
…droid Fix zlib building for Android Remove redundant patch comments
…3' into fix_aws_sdk_android
…aws_sdk_android
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please merge from master?
Thanks.
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
…cpkg into fix_aws_sdk_android
Done |
Ping @ras0219 @ras0219-msft for review again. |
Something is really wrong with the pipelines. Here it says that the pipelines are still in progress but here https://dev.azure.com/vcpkg/public/_build/results?buildId=52107&view=results all the tests passed successfully hours ago! |
@ahmedyarub it was an issue with the oauth token we think |
Describe the pull request
Adds toolchain chaining to external builds
What does your PR fix? Fixes #
Fixes Android builds. Same solution can be used in the future for any cross-platform builds.
Which triplets are supported/not supported? Have you updated the CI baseline?
x64-Android
Does your PR follow the maintainer guide?
Yes