Release v2.0.0-preview.3 (2018-03-08) (#147)

Services --- * Synced the V2 SDK with latests AWS service API definitions. Breaking Changes --- * `private/mode/api`: Refactor service paginator helpers to iterator pattern (#119) * Refactors the generated service client paginators to be an iterator pattern. This pattern improves usability while removing the need for callbacks. * See the linked PR for an example. * `private/model/api`: Removes setter helpers from service API types (#101) * Removes the setter helper methods from service API types. Removing clutter and noise from the API type's signature. * Based on feedback #81 * `aws`: Rename CanceledErrorCode to ErrCodeRequestCanceled (#131) * Renames CanceledErrorCode to correct naming scheme. SDK Bugs --- * `internal/awsutil`: Fix DeepEqual to consider string alias type equal to string (#102) * Fixes SDK waiters not detecting the correct condition is met. #92 * `aws/external`: Fix EnvConfig misspelled container endpoint path getter (#106) * This caused the type to not satisfy the ContainerCredentialsEndpointPathProvider interface. * Fixes #105 * `service/s3/s3crypto`: Fix S3Crypto's handling of TagLen (#107) * Fixes the S3Crypto's handling of TagLen to only be set if present. * V2 Fix for aws/aws-sdk-go#1742 * `private/model/api`: Update SDK service client initialization documentation (#141) * Updates the SDK's service initialization doc template to reflect the v2 SDK's configuration update change from v1. * Related to #136 SDK Enhancements --- * `aws`: Improve pagination unit tests (#97) * V2 port of aws/aws-sdk-go#1733 * `aws/external`: Add example for shared config and static credential helper (#109) * Adds examples for the config helpers; WithSharedConfigProfile, WithCredentialsValue, WithMFATokenFunc. * `private/model/api`: Add validation to prevent collision of api defintions (#112) * V2 port of aws/aws-sdk-go#1758 * `aws/ec2metadata`: Add support for AWS_EC2_METADATA_DISABLED env var (#128) * When this environment variable is set. The SDK's EC2 Metadata Client will not attempt to make requests. All requests made with the EC2 Metadata Client will fail. * V2 port of aws/aws-sdk-go#1799 * Add code of conduct (#138) * Update SDK README dep usage (#140)
aws · Mar 8, 2018 · 3383499 · 3383499
1 parent 309ad1c
commit 3383499
Show file tree

Hide file tree

Showing 221 changed files with 21,967 additions and 3,358 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,45 @@
+Release v2.0.0-preview.3 (2018-03-08)
+===
+
+### Services
+* Synced the V2 SDK with latests AWS service API definitions.
+
+### Breaking Changes
+* `private/mode/api`: Refactor service paginator helpers to iterator pattern ([#119](https://github.com/aws/aws-sdk-go-v2/pull/119))
+	* Refactors the generated service client paginators to be an iterator pattern. This pattern improves usability while removing the need for callbacks.
+	* See the linked PR for an example.
+* `private/model/api`: Removes setter helpers from service API types ([#101](https://github.com/aws/aws-sdk-go-v2/pull/101))
+	* Removes the setter helper methods from service API types. Removing clutter and noise from the API type's signature.
+	* Based on feedback [#81][https://github.com/aws/aws-sdk-go-v2/issues/81]
+* `aws`: Rename CanceledErrorCode to ErrCodeRequestCanceled ([#131](https://github.com/aws/aws-sdk-go-v2/pull/131))
+	* Renames CanceledErrorCode to correct naming scheme.
+
+### SDK Bugs
+* `internal/awsutil`: Fix DeepEqual to consider string alias type equal to string ([#102](https://github.com/aws/aws-sdk-go-v2/pull/102))
+	* Fixes SDK waiters not detecting the correct condition is met. [#92](https://github.com/aws/aws-sdk-go-v2/issues/92)
+* `aws/external`: Fix EnvConfig misspelled container endpoint path getter ([#106](https://github.com/aws/aws-sdk-go-v2/pull/106))
+	* This caused the type to not satisfy the ContainerCredentialsEndpointPathProvider interface.
+	* Fixes [#105](https://github.com/aws/aws-sdk-go-v2/issues/105)
+* `service/s3/s3crypto`: Fix S3Crypto's handling of TagLen ([#107](https://github.com/aws/aws-sdk-go-v2/pull/107))
+	* Fixes the S3Crypto's handling of TagLen to only be set if present.
+	* V2 Fix for [aws/aws-sdk-go#1742](https://github.com/aws/aws-sdk-go/issues/1742)
+* `private/model/api`: Update SDK service client initialization documentation ([#141](https://github.com/aws/aws-sdk-go-v2/pull/141))
+	* Updates the SDK's service initialization doc template to reflect the v2 SDK's configuration update change from v1.
+	* Related to [#136](https://github.com/aws/aws-sdk-go-v2/issues/136)
+
+### SDK Enhancements
+* `aws`: Improve pagination unit tests ([#97](https://github.com/aws/aws-sdk-go-v2/pull/97))
+	* V2 port of [aws/aws-sdk-go#1733](https://github.com/aws/aws-sdk-go/pull/1733)
+* `aws/external`: Add example for shared config and static credential helper ([#109](https://github.com/aws/aws-sdk-go-v2/pull/109))
+	* Adds examples for the  config helpers; WithSharedConfigProfile, WithCredentialsValue, WithMFATokenFunc.
+* `private/model/api`: Add validation to prevent collision of api defintions ([#112](https://github.com/aws/aws-sdk-go-v2/pull/112)) 
+	* V2 port of [aws/aws-sdk-go#1758](https://github.com/aws/aws-sdk-go/pull/1758)
+* `aws/ec2metadata`: Add support for AWS_EC2_METADATA_DISABLED env var ([#128](https://github.com/aws/aws-sdk-go-v2/pull/128))
+	* When this environment variable is set. The SDK's EC2 Metadata Client will not attempt to make requests. All requests made with the EC2 Metadata Client will fail.
+	* V2 port of [aws/aws-sdk-go#1799](https://github.com/aws/aws-sdk-go/pull/1799)
+* Add code of conduct ([#138](https://github.com/aws/aws-sdk-go-v2/pull/138))
+* Update SDK README dep usage ([#140](https://github.com/aws/aws-sdk-go-v2/pull/140))
+
 Release v2.0.0-preview.2 (2018-01-15)
 ===
 

diff --git a/aws/endpoints/decode.go b/aws/endpoints/decode.go
@@ -4,7 +4,6 @@ import (
 	"encoding/json"
 	"fmt"
 	"io"
-	"os"
 
 	"github.com/aws/aws-sdk-go-v2/aws/awserr"
 )
@@ -85,34 +84,11 @@ func decodeV3Endpoints(modelDef modelDefinition, opts DecodeModelOptions) (*Reso
 		custAddEC2Metadata(p)
 		custAddS3DualStack(p)
 		custSetUnresolveServices(p)
-
-		custFixCloudHSMv2SigningName(p)
 	}
 
 	return &Resolver{partitions: ps}, nil
 }
 
-func custFixCloudHSMv2SigningName(p *partition) {
-	// Workaround for aws/aws-sdk-go#1745 until the endpoint model can be
-	// fixed upstream. TODO remove this once the endpoints model is updated.
-
-	s, ok := p.Services["cloudhsmv2"]
-	if !ok {
-		return
-	}
-
-	if len(s.Defaults.CredentialScope.Service) != 0 {
-		fmt.Fprintf(os.Stderr, "cloudhsmv2 signing name already set, ignoring override.\n")
-		// If the value is already set don't override
-		return
-	}
-
-	s.Defaults.CredentialScope.Service = "cloudhsm"
-	fmt.Fprintf(os.Stderr, "cloudhsmv2 signing name not set, overriding.\n")
-
-	p.Services["cloudhsmv2"] = s
-}
-
 func custAddS3DualStack(p *partition) {
 	if p.ID != "aws" {
 		return

diff --git a/aws/endpoints/decode_test.go b/aws/endpoints/decode_test.go
@@ -115,126 +115,3 @@ func TestDecodeModelOptionsSet(t *testing.T) {
 		t.Errorf("expect %v options got %v", expect, actual)
 	}
 }
-
-func TestDecode_CustFixCloudHSMv2SigningName(t *testing.T) {
-	cases := []struct {
-		Doc    string
-		Expect string
-	}{
-		{
-			Doc: `
-{
-  "version": 3,
-  "partitions": [
-    {
-      "defaults": {
-        "hostname": "{service}.{region}.{dnsSuffix}",
-        "protocols": [
-          "https"
-        ],
-        "signatureVersions": [
-          "v4"
-        ]
-      },
-      "dnsSuffix": "amazonaws.com",
-      "partition": "aws",
-      "partitionName": "AWS Standard",
-      "regionRegex": "^(us|eu|ap|sa|ca)\\-\\w+\\-\\d+$",
-      "regions": {
-        "ap-northeast-1": {
-          "description": "Asia Pacific (Tokyo)"
-        },
-        "us-east-1": {
-          "description": "US East (N. Virginia)"
-        }
-      },
-      "services": {
-        "cloudhsmv2": {
-          "endpoints": {
-             "us-east-1": {}
-          }
-        },
-        "s3": {
-          "endpoints": {
-             "ap-northeast-1": {}
-          }
-        }
-      }
-    }
-  ]
-}`,
-			Expect: "cloudhsm",
-		},
-		{
-			Doc: `
-{
-  "version": 3,
-  "partitions": [
-    {
-      "defaults": {
-        "hostname": "{service}.{region}.{dnsSuffix}",
-        "protocols": [
-          "https"
-        ],
-        "signatureVersions": [
-          "v4"
-        ]
-      },
-      "dnsSuffix": "amazonaws.com",
-      "partition": "aws",
-      "partitionName": "AWS Standard",
-      "regionRegex": "^(us|eu|ap|sa|ca)\\-\\w+\\-\\d+$",
-      "regions": {
-        "ap-northeast-1": {
-          "description": "Asia Pacific (Tokyo)"
-        },
-        "us-east-1": {
-          "description": "US East (N. Virginia)"
-        }
-      },
-      "services": {
-        "cloudhsmv2": {
-          "defaults": {
-             "credentialScope": {
-                 "service": "coolSigningName"
-             }
-          },
-          "endpoints": {
-			  "us-east-1": {}
-          }
-        },
-        "s3": {
-          "endpoints": {
-             "ap-northeast-1": {}
-          }
-        }
-      }
-    }
-  ]
-}`,
-			Expect: "coolSigningName",
-		},
-	}
-
-	for i, c := range cases {
-		resolver, err := DecodeModel(strings.NewReader(c.Doc))
-		if err != nil {
-			t.Fatalf("%d, expected no error, got %v", i, err)
-		}
-
-		p := resolver.partitions[0]
-		defaults := p.Services["cloudhsmv2"].Defaults
-		if e, a := c.Expect, defaults.CredentialScope.Service; e != a {
-			t.Errorf("%d, expect %v, got %v", i, e, a)
-		}
-
-		endpoint, err := resolver.ResolveEndpoint("cloudhsmv2", "us-east-1")
-		if err != nil {
-			t.Fatalf("%d, failed to resolve endpoint, %v", i, err)
-		}
-
-		if e, a := c.Expect, endpoint.SigningName; e != a {
-			t.Errorf("%d, expected %q go %q", i, e, a)
-		}
-	}
-}